Hey there,
I like the feature. However, this addon makes users lose the bbpress “admin bar” allowing to edit a post or answer a topic.
This is quite a huge deal for me, so i just disabled your addon for now until it hopefully gets fixed.
I had to create a test user account to find this out since it didn’t affect the admin.
Since i’m not a php dev, i don’t really know where to look for to help you diagnosing this.
I’m also using quite a few wordpress modules so it might be a conflict.
I’m using the latest WP and BBP though.
Here is the full plugins list: https://image.noelshack.com/fichiers/2016/40/1475627030-screencapture-terageek-org-wp-admin-plugins-php-1475626998788.png
Please, tell me if there is anything -that wouldn’t take my website down- that can help you diagnose and fix this.
]]>Hey there! I just installed this plugin but I am not seeing anywhere that allows me to add a note. Where should this plugin add the functionality to add a note?
]]>Hi Pippin,
Thanks for adding the ability to reply to the main topics – that’s a great feature, much appreciated!
When upgrading, I noticed the following issue. I believe you are familiar with the Buddy-bbPress Support Topic plugin? Normally, the plugin displays a single selectbox, but with both that plugin and bbPress – Admin Notes enabled, it displays two
Here’s a screenshot: https://i.imgur.com/CBu7nRW.png
I did some debugging and here’s what I found:
1. bbPress – Admin Notes adds the extra “Add Note” admin button by adding its own span, so you end up with two <span class="bbp-admin-links"> elements. As you noted in your code comments – “This is kind of a hacky way of doing this for now” – there doesn’t seem to be a great way of handling this.
2. The bbPress – Support Topic plugin adds its selectbox via a str_replace (even hackier)
$new_span = str_replace( $r['before'], $r['before'] . $support_selectbox, $input );
(bbpress-functions.php line 360 for your reference)
What happens is that when the Support Topic plugin replaces that span.bbp-admin-links, it finds two strings that match, and therefore replaces the span twice, resulting in two selectboxes.
At the moment, I believe this is simply dependent on which plugin loads first.
Potential Workaround
Of course, a real solution would allow both plugins to add their custom elements without having to filter a string. But in the meantime, there’s a simple solution – if BBP Admin Notes changes its filter priority to ensure it runs after the Support Topic plugin, the issue is avoided because there is won’t be two matching strings when str_replace is called.
Basically, just changing line 122 from
add_filter( 'bbp_get_topic_admin_links', array( $this, 'add_topic_note_link' ), 10, 2 );
to
add_filter( 'bbp_get_topic_admin_links', array( $this, 'add_topic_note_link' ), 15, 2 );
fixes the issue.
Thought you might want to be aware of this, as a lot of users probably use these plugins in tandem and you may not even have noticed if your plugins happen to load in the reverse order.
Thanks, Pippin! ??
Chris
]]>Hi, good work with this, can be really useful.
I have 3 feature requests however that I think are really important (before I implement this into my site forums!):
1) Clicking on Add Note should cause the page to pan down (javascript for nice effect and avoid page-reload?) so you’re viewing the add note text area. This is because it’s odd to click on it and see no visual difference on a long post – I assumed it was broken at first!
2) There ought to be a way to edit your own note direct from the post. Edit link after your own notes?
3) In the admin interface, moderators and admins alike should be able to overview all notes by threads and admins should have power to delete / edit all from here.
Also, why does the word, ‘Quote’ appear after the add note / hide note link? https://i.imgur.com/A6K1y.jpg
Thanks,
Adam
https://www.ads-software.com/extend/plugins/bbpress-admin-notes/
]]>