Hi,
I’m very grateful for this plugin.
In the latest version, the [view code] option in the [affected Code] column inside the [Web Accessibility Report] isn’t showing code anymore, but a WYSIWYG variation of the entire page, which has made it very difficult to pin down the issue the plugin is flagging.
I don’t know if this was a deliberate change or not, but being able to see the actual HTML code I think is more beneficial for this plugin.
]]>ISSUE:
PHP Notice: Undefined variable: errorfound in …/wp-ada-compliance-check-basic/res/rules/empty_th.php on line 35
Causing the update of a post that contains a table with no errors to fail with the message “Updating failed. Undefined variable: errorfound”.
SOLUTION:
Check if $errorFoundis not empty:
if (!empty($errorfound) && $errorfound == 1) {
...
}Greetings,
In testing this Plugin and clicking the ‘Start Scan’ button, there was created an error log that was 1.1 MB in size and 641 lines long, mostly WordPress database errors because a Table is not created but repeatedly called for.
WordPress database error Table ‘db_name.wp32_wp_ada_compliance’ doesn’t exist for query SELECT id FROM wp32_wp_ada_compliance where object =
*db_name is used in this example instead of actual db name – for security reasons
Version: 3.0.5 WordPress 6.1.1 PHP 7.4
Is this just me or has there been any testing for errors and none were created?
]]>Currently running PHP 8.0 and after updating license key/plugin software receiving the message:
WP ADA Compliance Plugin – Additional Setup
PHP Fileinfo: Your server does not have the PHP Fileinfo Extensions enabled. Issues in theme content will not be corrected.
Where is the setting to enable. Can’t seem to locate. Any guidance would be greatly appreciated!
Thanks in advance!
As it is now, the notice shown suggesting people check out the HTML Validation plugin (https://www.ads-software.com/plugins/html-validation/) is dismissible, but that doesn’t have any code seeing if it’s been dismissed (per https://plugins.trac.www.ads-software.com/browser/wp-ada-compliance-check-basic/trunk/wp-ada-compliance-basic.php#L357 [it just sees if the plugin is installed or not & doesn’t see if the notice has been previously dismissed]).
As such, it keeps showing this notice even when it’s previously been dismissed. Having this be a persistent notice is really something that can rub people the wrong way & have them look to go elsewhere to avoid having something like that always shown (for those that don’t want or otherwise have an alternative to the HTML Validation plugin.)
?Proposed fix for this notice:
Hi, after the latest update of WP ADA Compliance Check Basic, OLD Tabs from WPBakery doesn’t work now.
Is there any way I can download the old version of ADA Compliance Check plugin?
Thanks!
]]>I am managing a site where the client has a lot of older pages and posts set to draft instead of deleted and they are flooding the scan report with errors that don’t need to be addressed. So is there a scan published only setting?
]]>Plugin Version: 2.3.11.1
Hosting Environment: WPEngine, PHP 7.3
Uncovered a strange issue today, though my client states it started months ago.
We are unable to save/update a page or post without the site throwing a 500 error. After trial and error (enabling default theme, disabling all plugins, re-enabling one by one), we came to the conclusion that it was this one causing the issue.
This is the error in the logs
[Thu Apr 29 18:09:17.260852 2021] [php7:error] [pid 30824] [client 66.162.212.19:38406] PHP Fatal error: Uncaught Error: Call to undefined function wp_ada_compliance_check_basic_if_alt_text_includes_exclusion() in /nas/content/live/MY_WEB_SITE/wp-content/plugins/wp-ada-compliance-check-basic/res/rules/img_linked_to_self.php:31\nStack trace:\n#0 /nas/content/live/MY_WEB_SITE/wp-content/plugins/wp-ada-compliance-check-basic/res/content_validation.php(173): wp_ada_compliance_basic_validate_img_linked_to_self('<p>wpe test 4</...', Array)\n#1 /nas/content/live/MY_WEB_SITE/wp-content/plugins/wp-ada-compliance-check-basic/res/content_validation.php(48): wp_ada_compliance_basic_complete_content_validations('<p>wpe test 4</...', Array)\n#2 /nas/content/live/MY_WEB_SITE/wp-content/plugins/wp-ada-compliance-check-basic/res/content_posts.php(61): wp_ada_compliance_basic_validate_post(Array)\n#3 /nas/content/live/MY_WEB_SITE/wp-includes/class-wp-hook.php(289): wp_ada_compliance_basic_validate_ada_post_compliance(1, Object(WP_Post))\n#4 /nas/content/live/MY_WEB_SITE/wp-includes/class-wp-hook.php(311): WP_Hook->apply_filters(1, Arra in /nas/content/live/MY_WEB_SITE/wp-content/plugins/wp-ada-compliance-check-basic/res/rules/img_linked_to_self.php on line 31, referer: https://MY_WEB_SITE.wpengine.com/wp-admin/post.php?post=1&action=edit
Will 1 of these plugins scan multiple sites within a multisite WordPress installation? And (in addition to pages & posts) will the plugin scan other pages offered in themes like member, gallery, service, program pages (that exist outside and functions differently from traditional pages/posts?
]]>Why is Font Awesome being loaded on the public pages by the WP ADA Compliance Check plugin? I have a client wanting to optimize their website, and they currently have Font Awesome being loaded via the official Font Awesome plugin to then be used site-wide for their specific needs while they then also have the paid version of the accessibility check plugin which then seems unneeded (also seems to be a similar situation with the free plugin version.)
I can understand it being on the admin pages if it’s being used there, but how is it being used on the public pages? If it’s for admin purposes, shouldn’t it check if the visitor is currently logged in & is a sufficient role before including it so people that don’t need it don’t have unnecessary assets being loaded? If it’s for the “open in new tab/window” icon indicator, then shouldn’t it check against the settings to determine if that behavior is actually enabled? I have the site not having the plugin alter any content so the fact it’s loading an icon library for public visitors which is then effectively doing nothing seems like it should be updated. Hopefully this is a quick fix to have the points where Font Awesome is included be wrapped in a sufficient conditional statement (be it checking current user status/role and/or plugin settings) so it’s only included when it should be.
Also, it seems odd that the free & paid versions have Font Awesome being called in via different methods with different assets being loaded (paid version has the JS version of FA while the free version has it loaded via CSS from my initial inspection; seems odd & likely worthwhile to unify how this is done when changing how these are loaded in [only include when actually used] on both.)
Let me know if I should provide any additional information or anything.
Thanks,
Kurt
Can we use this plugin to check ADA compliance for a plugin that runs in the wp-admin/backend only?
]]>Hi, I am trying out your software on a staging site which is also on maintenance mode right now and password protected for anyone. It also does have the SSL certificate installed. I am getting the message: “50 posts or pages are unprotected” and I don’t understand why. Could you please explain? Also, it says this would be fixed in pro version. Could you please explain what is actually being done to these files in the pro version? Thank you
]]>Hi,
I am currently running WordPress 5.3 and version 2.2.10 of the WP ADA Compliance Checker Basic. On my blog I am able to create a post and save it. However I am unable to make any changes to the post or edit it after.
I deactivated the WP ADA Compliance Checker Basic plugin and was able to save and edit a blog post as normal. I then deleted it and re-installed it and experienced the same issues as before.
Any help debugging the inability to edit, save or preview posts due to the plugin would be great. This issue started on 11/12/19.
]]>What is the best online tool for checking ADA Compliance before and after using this plugin? I’d like to install and run the plugin but would like to have some kind of before/after to compare results.
Thanks!
]]>We have started receiving this message when trying to update a page or post. The version of the plugin that we are using is version Version 2.2.9
Error Details
=============
An error of type E_ERROR was caused in line 285 of the file /www/wp-content/plugins/wp-ada-compliance-check-basic/res/content_validation.php. Error message: Uncaught Error: [] operator not supported for strings in /www/wp-content/plugins/wp-ada-compliance-check-basic/res/content_validation.php:285
Stack trace:
#0 /www/wp-content/plugins/wp-ada-compliance-check-basic/res/content_validation.php(16): wp_ada_compliance_basic_strip_shortcodes(‘[et_pb_section …’)
#1 /www/wp-content/plugins/wp-ada-compliance-check-basic/res/content_posts.php(55): wp_ada_compliance_basic_validate_post(Array)
#2 /www/wp-includes/class-wp-hook.php(288): wp_ada_compliance_basic_validate_ada_post_compliance(53857, Object(WP_Post))
#3 /www/wp-includes/class-wp-hook.php(310): WP_Hook->apply_filters(NULL, Array)
#4 /www/wp-includes/plugin.php(465): WP_Hook->do_action(Array)
#5 /www/wp-includes/post.php(3951): do_action(‘save_post’, 53857, Object(WP_Post), true)
#6 /www/wp-includes/post.php(4028): wp_insert_post(Array, false)
#7 /www/wp-admin/includes/post.php(405): wp_update_post(Array)
#8 /www/wp-admin/post.php(218): edit_post()
#9 {main}
thrown
Don’t know if this is something I’m doing wrong or what but while evaluating this tool I’m finding that a lot of the posts that are getting flagged for fixes are deleted items. Is there a way to bypass anything that is not published?
]]>Hi, support team. I have modified my css files and removed some content but same things are being suggested by plugin to modify. Please help me on that. Is it a bug on your plugin?
]]>It seems odd that the plugin (both free/basic and paid) is currently going out of its way to introduce non-standard styling for interface elements (buttons, tables, boxes, etc.) I think it’d look less “janky” (which can scare potential users away to alternatives) to have it follow the established styling for the WordPress admin as well as reducing the overall code needed for the plugin (in terms of both management & unnecessary bloat). As an aside, some site admins have custom/unique styling so the WP ADA Compliance Check styles stand out even worse at that point.
It also doesn’t appear to be using non-standard styles in service of branding or anything like that so I’m seeing no reason to not just use the established WordPress element classes, etc. to apply the appropriate styling automatically.
For example, settings.php could have:
echo '
<div>
<form action="options.php" method="post" id="ada_compliance_options">';
settings_fields('wp_ada_compliance_basic_options');
wp_ada_compliance_basic_do_settings_sections_tabs('wp_ada_compliance_basic');
echo '<input name="Submit" type="submit" value="';
_e('Save Changes', 'wp-ada-compliance-basic');
echo '" />
</form></div>';
echo '<a id="adascrollbutton" aria-label="Top"></a>';
echo '</div>';
could instead be:
echo '
<div>
<form action="options.php" method="post" id="ada_compliance_options">';
settings_fields('wp_ada_compliance_basic_options');
wp_ada_compliance_basic_do_settings_sections_tabs('wp_ada_compliance_basic');
echo '<input class="button button-primary" name="Submit" type="submit" value="';
_e('Save Changes', 'wp-ada-compliance-basic');
echo '" />
</form></div>';
echo '<a id="adascrollbutton" aria-label="Top"></a>';
echo '</div>';
so it’s shown as WordPress’ primary button styling. This could be done accross the whole plugin since btn equates to button, btn-primary turns into button-primary, btn-secondary is button-secondary, etc. Seriously, this could be a find & replace for the plugin to update this in one go. Here’s a screenshot of much much more native/integrated this looks than what’s being used now on the report page of the baisc plugin: https://cloudup.com/cLoyLleLybN (you can see how I also decided that not every button is “primary” and used “secondary” as well).
Also, classes like wp_ada_compliance_basic_report can be replaced with postbox-container, the wp_ada_summary + wp_ada_form + more classes could be replaced with the postbox class with an interior div with a class of inside (containing the content of the postbox) to then implement the appropriate padding. From there, adding an h2 element with a class of hndle could be utilized for giving the sections headings, and so on. Then you just need to implement the column layout. You can see more about metaboxes & their styling here: https://developer.www.ads-software.com/plugins/metadata/custom-meta-boxes/
Similarly, I’m left wondering why the Error Report layout doesn’t use the wp-list-table widefat fixed striped classes & table setup that you see on the native WordPress Pages => All Pages site admin page. It’d look much nicer right away and allow for the custom CSS to focus on what’s unique for this plugin.
Again, this seems like a large amount of CSS could be purged from the plugin and all will benefit from having done so.
Let me know if you would like any assistance with this, because it’d love to see this cleaned up in an upcoming version of both the free & paid plugins.
Thanks for the great plugin!
Kurt
The ADA plugin is currently incorrectly interpreting memory_limit and is actually setting it lower than what I have the server set to (this is something that appears to only be present in the paid version since the free/basic version doesn’t work with memory_limit at all, currently).
I have the server’s memory_limit set to 2G, but it’s currently seeing that as being less than 256 due to it not converting the memory_limit to bytes first (it then sets the memory_limit to 256MB which gives it more limited resources than the 2GB I want to give it).
– I’ve come up with a suggested patch to fix this. –
You can see the updated startup.php and res/installation.php files here: https://gist.github.com/KZeni/1aa295bd6298a5a89e4d36613479bfd4 (see revision history enabled between the current version & the new ones: https://gist.github.com/KZeni/1aa295bd6298a5a89e4d36613479bfd4/revisions [note: I have trailing whitespace automatically removed by my editor so it’s showing more edits than what I really made.])
Essentially, I added the new return_bytes() function to the very top of the startup.php file so it can be used throughout the plugin as needed (it’s called by both startup.php and installation.php). I then swapped out the memory_limit code in startup.php for https://gist.github.com/KZeni/1aa295bd6298a5a89e4d36613479bfd4#file-startup-php-L285 (notice how bytes are also used for setting the memory_limit to prevent the notice in installation.php from being triggered [they’re on the same page]) and then swapped out the memory_limit code in installation.php for https://gist.github.com/KZeni/1aa295bd6298a5a89e4d36613479bfd4#file-installation-php-L454 (notice the minor text change to the message as well as the if condition).
I would love to see this officially implemented in the next update to the plugin.
Btw, I submitted this via the contact us form at https://www.alumnionlineservices.com/contact-us/, but I didn’t get a confirmation email so I submitted this here as well just in case it didn’t go through.
]]>I have the pro version.
I’ve implemented the solution that puts the small icon on external links. This works for most links but it does not seem to work correctly with links that open external windows via javascript.
Here is what is happening:
<a href="javascript:void(0)" onclick="window.open('https://www.externalsite.com/7711/visitor/window/?code_id=615&dl='+escape(document.location.href),'wsa_7711_0','height=200,width=200')" class="adaNewWindowInfo"><i class="fa fa-external-link" aria-hidden="true"></i><span class="wp_ada_hidden"> opens in a new window</span></a><span class="dakHeadLink">Link Is Here</span>
The closing a tag for the link should appear at the end after the closing span tag for “Link Is Here” which it did before I used the plugin. Now, the a tag is being closed prematurely. How can this be fixed?
Thanks
]]>Just wanted to let you know that the plugin is currently always using wp_ as the table prefix for the wp_ada_compliance table rather than using what’s specified in the wp-config.php file. This seems like an issue of the plugin complying with common & established WordPress plugin conventions (this one being a possible security concern, conflict if there’s multiple sites using this plugin in a single database, etc.), and hopefully it’ll be a quick & easy fix.
I’d imagine this plugin should check to see if the wp_ada_compliance the table exists when wp-config.php has the prefix set to something else when upgrading from a previous version and rename it accordingly (taking care of existing installations), and then have it so all calls to the table always use the specified table prefix everywhere else in the code (simply just using the preferred setup from then on). I’m assuming this is also the case for the paid plugin as much as it is for the free version, currently.
Thanks for the great plugin and support,
Kurt
I submitted this request via the official site’s contact us form, but I’ve also posted this here for better visibility (could help others in the meantime).
I have the paid version of the plugin, but this may also apply to the free version as they share the same code for this (though the free version doesn’t increment its scans so it might be unnecessary for that version).
Within res/reports.php, updated it so that:
$current_cron_count = get_option('wp_ada_compliance_cron_count','0');
if($current_cron_count != 0 and isset($_GET['startscan'])) {
is instead:
$current_cron_count = get_option('wp_ada_compliance_cron_count','0');
$scan_increment = get_option('wp_ada_compliance_scan_increment','0');
if( ($current_cron_count != 0 and isset($_GET['startscan'])) || (isset($scan_increment) and $scan_increment > 0) ) {
Note: Replace wp_ada_compliance_cron_count for wp_ada_compliance_basic_cron_count with the basic version of the plugin.
You can see how I made it check for the scan_increment status and not just the current_cron_count.
This way, leaving the report page and then coming back do it doesn’t have “Start Scan” shown which starts the scanning process over entirely. Instead, one can perform manual scans, leave the page, and then return to continue their scanning progress. The scan then restarts once the scan_increment has exceeded the total items as it would normally with performing a scan all at one time (no edit needed there).
I bring this up since I have a site with tens of thousands of items being checked and having that restart the scan unless it’s all done in one session is just not an efficient & friendly experience.
Maybe there’s additional items to be accounted for (maybe having a “Reset Scan” button added to the report toolbar could be helpful), but I think this is a quick & easy adjustment which would make life easier for myself, my coworkers, and my clients.
Thanks for the great plugin,
Kurt
Hi,
After updating to 2.1.2 my menu appears to be malformed and is now showing as a vertical list rather than horizontal as dictated by my theme.
]]>The social links at the top of our web pages (Facebook, Twitter, etc.) have a title attribute, but no alt attributes. Therefore, they are throwing a compliance error. These links are icons and have no alt attributes by default and do not reside in the media library, but are built into the site theme. I purchased your plugin today, installed and activated it, then scanned my entire site. I ensured I had the setting selected for “Convert all title attributes to aria-label attributes.” However, that doesn’t seem to be doing the trick.
Any suggestions on how your plugin could help me with this issue? Many, many thanks!
]]>I’m getting “Failed to load plugin url: https://www.site.com/wp-content/plugins/wp-ada-compliance-check-basic/res/editor.php?postid=117434&site=https://www.site.com” shown overlaying the visual editor.
I have Sucuri Security (https://www.ads-software.com/plugins/sucuri-scanner/) set to harden PHP script behavior so that no PHP script can be directly called within plugins & elsewhere on the site as a security precaution.
I’m thinking that’s what’s happening here with it unable to load a resource which is being called via a direct PHP file call. Best practices for WordPress would have this handled without requiring a direct call to a PHP script & would also eliminate this conflict.
Thanks for the great plugin!
]]>