1.2alpha and Smilies hack

  • Running 1.2a 1/3/04 build.
    Using the wp_grins hack (which I have been for a while).
    Similies directory is correct in Options.
    Clicking a comment, or viewing an archived post, results in the ‘alt’ text being displayed.
    I ‘View Source’ and see this;
    <div id="wp_grins">
    <img src="/icon_mrgreen.gif" alt=":mrgreen:" onclick="grin(':mrgreen:');"/>
    so it seems to me that the path to the image is wrong.
    Any ideas ?
    (Btw, the rest of the build looks great so far, and I really like the new admin interface!)

Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter Mark (podz)

    (@podz)

    Smilies are being correctly interpreted when code is output as part of something someone has written – either in the blog or in comments – and I’ve stared at the wp_grins code. I assume that the variable $smilies_directory had changed somewhere ?
    It worked in the 28/2 build.
    There’s another smilies hack around, so I’ll use that for now.

    Anonymous

    I think they have removed all old b2 variables defined in wp-settings.php and made them nonglobal. You can only access these variables by using get_settings(‘variable name’).
    Check your wp_grins code and change the way it refer $smilies_directory to get_settings('smilies_directory') and it should work again.

    Thread Starter Mark (podz)

    (@podz)

    Thanks for the pointer as to where to look.
    But so far, no joy.
    wp-grins.php has this as the first few lines originally:
    function wp_grins() {
    global $smilies_directory, $wpsmiliestrans;
    $grins = ”;
    $smiled = array();
    If I alter the ‘global line’ I get an error on the $grins=”; line
    This fails:
    function wp_grins() {
    get_settings(‘$smilies_directory , $wpsmiliestrans’)
    $grins = ”;
    $smiled = array();
    as does this:
    function wp_grins() {
    get_settings(‘$smilies_directory , $wpsmiliestrans , $grins , $smiled’)
    $grins = ”;
    $smiled = array();
    I get this error on screen:
    Parse error: parse error in /home/–path–/T2/hacks/wp-grins.php on line 20 (this being the $grins line)
    I’ll play around later though…

    Moderator Matt Mullenweg

    (@matt)

    Pods, you modified it the wrong way, the global line should look like:
    global $wpsmiliestrans;
    and then after that you can put:
    $smilies_directory = get_settings('smilies_directory');

    Thread Starter Mark (podz)

    (@podz)

    Many thanks ! Works great now …
    That hack isn’t in the Wiki, but the code for the top few lines is now:
    function wp_grins() {
    global $wpsmiliestrans;
    $smilies_directory = get_settings(‘smilies_directory’);
    $grins = ”;
    This works in 1.2 alpha 1/3/04 build.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘1.2alpha and Smilies hack’ is closed to new replies.