• Resolved spiralofhope

    (@spiralofhope2)


    footnotes 2.0.5

    PHP version 7.3.21
    WordPress version 5.5.3

    foot notes was rather heavily broken until I reverted back to 2.0.3 (from SVN).

    For example, a page with one line:

    test (( testing ))

    This will generate two footnote entries.

    It gets much worse than this, but that’s simple to reproduce.

Viewing 7 replies - 1 through 7 (of 7 total)
  • mmallett

    (@mmallett)

    Yes, the footnotes no longer appear at the bottom of my pages. Maybe they are doing live testing??

    Plugin Contributor pewgeuges

    (@pewgeuges)

    @spiralofhope2, @mmallett,

    I’m extremely saddened to see that the bugfix I did and that worked well in my sandbox with Twenty Twenty, is breaking the display in other instances. Longlasting bugs were addressed, and the fix was released for everybody to fix their websites. I didn’t expect that it would backfire.

    @mmallett you shared your URL and I was able to check and respond over there, yet @spiralofhope2 you didn’t so I don’t have a chance to look into it and assess what it takes to fix it.

    For now, I can safely recommend that you discard any v2.0.5 that got out the door and install our release candidate 1 instead. Its changelog is also posted in https://www.ads-software.com/support/topic/auto-load-post-compatibility-update/#post-13623000

    For v2.0.5rc1 I reverted the priority edits that fixed the misordering of notes container below related posts and social icons but caused issues that I couldn’t see on my test site. That is now undone, and the related bugs are back again but don’t affect your websites, at least as far as I can see.

    Currently v2.0.5rc1 is available at the bottom of https://www.ads-software.com/plugins/footnotes/advanced/

    This has been tested and debugged, and I know what the changes do. There are no critical changes.

    From today’s viewpoint I acknowledge that changes in priority with the add_filter() function of WordPress should have been subject to a heavy assessment process, hangouts and what not. I found no warning when I checked the documentation.

    Hopefully everything now returns to normalcy, so that we can go on fixing more bugs and eventually, if some time is left, add missing features.

    Please let us know how it works out on your particular websites. Each site may be unique, some widespread themes have display bugs at least in the mobile view emulator of Chrome, affecting the footnotes reference container too, while other themes like Twenty?Twenty are free from these bugs.

    @spiralofhope2: If you would like to share the name of your theme too and it’s free, I’ll try it out with footnotes.

    Best regards,
    @pewgeuges

    • This reply was modified 4 years ago by pewgeuges.
    widecast

    (@widecast)

    Hello @pewgeuges,

    I’d also like to report a bug in 2.0.5 and the new development version.

    I’m seeing references from other posts that shouldn’t be there on the page. The plugin seems to somehow be grabbing the ref shortcode from other posts.

    This is happening for a custom post type, in case that’s relevent.

    Thank you!

    Plugin Contributor pewgeuges

    (@pewgeuges)

    @widecast,

    Please try to uninstall and re-install the pluging. I’ll do further research in a working model and we’ll tell you more when we’ve found the problem.

    I apologize for v2.0.5. It is now superseded since an hour by v2.0.6 that brings various bug fixes and above all, reverts the change in priority level that seems to cause so much trouble. It was a proven edit that fixed the relative position of various features and the footnotes list. While this is supposed to come close after the article, it is often moved down to the benefit of related posts and social buttons.

    Only today I noticed that the bug is actually in the other plugins, not in Footnotes. Replacing an internal variable by PHP_INT_MAX as a priority argument in the add_filter() function e.g. in the YARPP extension does the same trick.

    Best regards,
    @pewgeuges

    Thread Starter spiralofhope

    (@spiralofhope2)

    I deleted my existing footnotes plugin and installed the recommended developer version. I see no change.

    With one line:

    test (( testing ))

    I get test [2] with two footnote “testing” entries.

    I am using Parament:

    https://blog.spiralofhope.com/?p=4761
    https://www.ads-software.com/support/theme/parament/

    I made a child theme to adjust some colors and such.

    I don’t understand how this can be a theme problem, but I can continue to try to troubleshoot.

    Thread Starter spiralofhope

    (@spiralofhope2)

    2.0.8 appears to work the way I expect; thank you for your efforts!

    To get this version installed correctly, I deactivated and then deleted my 2.0.3 upload, and then I installed footnotes from the WordPress plugin finder.

    Plugin Contributor pewgeuges

    (@pewgeuges)

    @spiralofhope2, @widecast

    I beg your pardon. Thank you for letting us know how current 2.0.8 got you out of trouble. Please read https://www.ads-software.com/support/topic/change-the-position-5/page/2/#post-13630114 about how the bug was found. The harmful feature will totally disappear from the plugin.

    Best regards.

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘2.0.5 broken’ is closed to new replies.