2017 Theme Banner Issue on Phone only

  • Love the 2017 Theme!

    In the theme – customize – header/media panel my mp4 video (2000 x 1200px) uploaded and shows up in the banner section on the computer and on the iPad as expected. However, it doesn’t show up on the iPhone version of the theme although it shows when I click the preview button in the header/media customize panel. I uploaded a photo using the interface below, thinking only photos would display on the smaller screen. It doesn’t display either. The very clean/nice default 2017 Theme image displays only. On my server, I went in to wp-content – themes – 2017 – assets – images and renamed the header file it insists on using and placed the file I want it to display in there, naming it header.jpg. It works. I tried uploading the mp4 video file named header.mp4. It doesn’t work.

    So, what’s the issue on the phone when I upload an image via the theme customization panel? Will a video not play on the phone? (The phone is fully capable of doing so.) And why doesn’t a photo uploaded in the header/media customize panel get used either?

    Am I just missing something basic, or is this a bug?

Viewing 15 replies - 16 through 30 (of 34 total)
  • Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    I’m sorry. I’ve fixed that just now and updated the code. Can you try again?

    Thread Starter timtyson

    (@timtyson)

    OK. So, the page now loads. The video plays on the desktop, but not on the iPhone, just as before.

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    Would you be able to link your website? I need to check whether the code had absolutely no effect by looking at the underlying code running when your website is viewed.

    Thread Starter timtyson

    (@timtyson)

    Sure: https://pencewatch.us

    The code is running now.

    Thread Starter timtyson

    (@timtyson)

    Is the forum messing up on your end? I can’t get it to post over here when I put in the link

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    Yea the forum was messing up, thanks for trying to post it though – I fixed one of your posts.

    Thread Starter timtyson

    (@timtyson)

    Man that was weird. Even the link command in the toolbar wouldn’t publish. Hope the link makes sense

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    Ah my recommended code had 0 effect, hmm. I’ve asked Sterndata to help.

    Thread Starter timtyson

    (@timtyson)

    Thanks for your help, Andrew. I’ll take the code out in the meantime.

    Moderator Samuel Wood (Otto)

    (@otto42)

    www.ads-software.com Admin

    Yeah, that code is all wrong. Forget that code.

    I assume Andrew was trying to set the minWidth and minHeight to zero? If so, try something like this instead:

    
add_filter( 'header_video_settings', 'childtheme_adjust_header_video_settings' );
function childtheme_adjust_header_video_settings( $settings ) {
	$settings['minWidth'] = 0;
	$settings['minHeight'] = 0;
	return $settings;
}

    That will change those without all the extra unnecessary steps and the infinite loop issue.

    Thread Starter timtyson

    (@timtyson)

    Hi guys. Tried it. The revised code is live now. Still not video on the phone.

    A strange piece to this puzzle (to me, anyway) is that it plays the video in the phone preview on the customize panel in WP itself. All three of the previews (computer, tablet, and phone) work as you would expect.

    • This reply was modified 8 years, 2 months ago by timtyson.

    I am having the same issue except it is on an android mobile phone. I would really like to have the video be able to play on mobile phones since this is where most traffic to site comes through. Is there a solution to this yet? I have tried it on multiple devices so it is apparently not just my device that is having this occur.

    Thread Starter timtyson

    (@timtyson)

    Summary: They say it’s not a bug. The video will not play in browsers below a certain size (phone browsers are too smal), and I couldn’t get the code work around (above) to work. Maybe you can.

    Moderator Steven Stern (sterndata)

    (@sterndata)

    Volunteer Forum Moderator

    Otto’s code sort of works. If I view on my desktop in a narrow browser, then then video plays (though the area in which it plays isn’t quite right), but it doesn’t play in a visible area on my iPhone.

    https://bertha.sterndata.com

    code at https://github.com/sterndata/bertha/blob/master/functions.php

    So the solution is to change the mninimums but there may need to be additional CSS applied to get things looking good.

    Neither code worked for me. Does anyone know of a solution to get the video to play on a phone?

    • This reply was modified 7 years, 8 months ago by IndyITguy.
Viewing 15 replies - 16 through 30 (of 34 total)
  • The topic ‘2017 Theme Banner Issue on Phone only’ is closed to new replies.