4.3.5 Full CSS Changes Break Single Event Layout

  • Resolved jjbte

    (@jjbte)


    8 years, 2 months ago

    I updated to 4.3.5 and my single event layout was all messed up as a result. I saw another thread regarding a similar issue.

    I am using the Full Styles option on my site and I compared the tribe-events-full.css files from versions 4.3.5 and 4.3.1.1. I found three instances where the CSS went from targeting featured images in list view to targeting all featured images. For instance, line 615 in 4.3.1.1 was:

    .tribe-events-list .tribe-events-event-image {
	display: inline-block;
	float: left;
	margin: 0 3% 0 0;
}

    However, that line is now line 610 in 4.3.5 and it has been changed to:

    .tribe-events-event-image {
		display: inline-block;
		float: left;
		margin: 0 3% 0 0;
	}

    This means that all featured images are now affected by this code rather than just the images appearing in list view.

    I managed to fix the single-event layout on my site by adding the following to my theme’s CSS file:

    .single-tribe_events .tribe-events-event-image {
  float: none;
  display: block;
  margin-right: 0;
}
.single-tribe_events .tribe-events-event-image img {
  width: auto;
}
.single-tribe_events .tribe-events-event-image + div.tribe-events-content {
  float: none;
  position: static;
  width: auto;
}

    However, I am wondering why the change (removing .tribe-events-list) was made at all. And can it be reverted to the way it was? I noticed the same change was not made to the mobile full CSS file.

Viewing 7 replies - 1 through 7 (of 7 total)

  • Thank you @jjbte!

    I was having exactly the same problem as you, but with the Tribe Events Styles against the Default Page Template in the Hemingway theme.

    A quick Google brought me here and your suggestion has fixed the problem for me.

    • This reply was modified 8 years, 2 months ago by SingingDwarf.
    Thread Starter jjbte

    (@jjbte)

    You’re very welcome, @singingdwarf. I’m glad to be of help.

    I just wish they’d tell us why the change was made. I hate having to add extraneous CSS for situations like this. I can’t think of a good reason for this change, but I’m hoping the plugin developers will either explain or fix. There is at least one other thread regarding this issue, so we’re not the only ones affected.

    There is a reply in this thread from @geoffgraham 13-days ago saying that they are working on a fix.

    There are also some replies from @tribecari in three separate threads where users have reported problems with the spacing of events within the widget (another problem that I am experiencing):

    https://www.ads-software.com/support/topic/extra-space-in-events-list-widget/
    https://www.ads-software.com/support/topic/too-much-blank-lines-in-widget/
    https://www.ads-software.com/support/topic/4-3-5-widget-padding-issue/

    The fix is again modifying the CSS, which I don’t like either.

    Looks like there were some quality control issues with this build

    Hey @singingdwarf,

    This is indeed the same issue mentioned in other topics and the layout issue definitely did slip under our radar in the testing process, though I would say that is an exception rather than a rule when it comes to our Quality Assurance practices.

    In either case, I have made a note of this thread in the ticket we have open to fix it. That fix is (ironically) in testing and is expected to release in Version 4.4, which is just around the corner.

    Cheers!
    Geoff

    Thread Starter jjbte

    (@jjbte)

    Thanks so much for this additional info, @singingdwarf and @geoffgraham! The past few weeks have been very busy and I didn’t get a chance to update to 4.3.5 until a few days ago. I saw one thread in my search, but not the others. Plus the moderators often ask us to post our own threads, so I thought it best to do so. The other thread I saw didn’t specify which Basic Template Settings the users had in place. I also wanted to share my fix in case it might help someone else.

    I’ve had good luck with this plugin. I’ve been using it for nearly a year and this is the first update that’s caused any real issues for me.

    Heck yeah, thanks @jjbte! We’re definitely sorry to have shipped a front-end error like this but the next update should smooth this out a ton and get things back on track.

    Cheers to you and thanks for using The Events Calendar!

    Geoff

    Hi there!

    Just wanted to share with you that a major release of our plugins is out, which includes a definitve fix for this issue ??

    Find out more about the release → https://theeventscalendar.com/things-to-be-aware-of-in-version-4-4-of-the-events-calendar-event-tickets-and-premium-add-ons/

    Best,
    Nico

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘4.3.5 Full CSS Changes Break Single Event Layout’ is closed to new replies.