_n

Very good suggestion. We will definitely add this.

Thanks for answer.

Of course correct way will be:
$string = _n(‘Download’, ‘Downloads’, $db_count, ‘sdm_lang’);

also i18n issue here

sdm-logs-list-table.php

parent::__construct(array(
            'singular' => __('Download', 'sdm_lang'), //singular name of the listed records
            'plural' => __('Downloads', 'sdm_lang'), //plural name of the listed records
            'ajax' => false        //does this table support ajax?
        ));

prevents items from mass deleting from the download log

what i’ve done:
1. added DownloadX and scan-field _n:1,2 to poedit
2. ‘Download’ and ‘Downloads’ keeped untranslated
3. applied patch https://pastebin.com/B5dJBDYg (also swaps ‘Download’ and download counter)

ps. my lang ru_RU and there is no translation inside the package, so here is my translation
https://www.dropbox.com/s/3evrhshrxh6chuc/langs_ru.zip?dl=0

refresh patch and translation
https://www.dropbox.com/s/3evrhshrxh6chuc/langs_ru.zip?dl=0
https://www.dropbox.com/s/k3k655jv6viv46a/patch.diff?dl=0

Hi,

Thank you very much for taking the time to help us make this a better plugin.

I’m not entirely familiar with translations; so I’m going to take your word the changes are okay. You seem to know exactly what you are talking about… so I’m sure as long as I follow your diff, we’ll be okay.

I’ll work with the plugin author; and see if we can get this implemented in the next plugin release.

Again, thank you for your time!