A little surprised at results, Jetpack, for example fails 5.4

  • Resolved MiKemp

    (@mikemp)


    8 years, 4 months ago

    Thanks for the plugin, just giving a first run, and I’m in no way, shape or form knowledgeable on PHP. Just looking for your comments here, to try to learn more and understand what might produce these results.
    TYIA.
    Started out wanting to check for PHP7 compatiblity, and worked backwards from there.
    I won’t list details for all the plugins and all the versions that “failed,” but will use Jetpack as an example. Jetpack was only reported compatible at 5.3. The Jetpack team thinks it’s compatible all the way to 7 (see https://www.ads-software.com/support/topic/php-7-jetpack-compatibility).
    The error on 5.4 for Jetpack is
    FILE: /home/sitehidden/public_html/wp-content/plugins/jetpack/_inc/lib/markdown/extra.php
    —————————————————————————————
    FOUND 5 ERRORS AFFECTING 5 LINES
    —————————————————————————————
    1739 | ERROR | Using a call-time pass-by-reference is prohibited since php 5.4
    2329 | ERROR | Using a call-time pass-by-reference is prohibited since php 5.4
    2439 | ERROR | Using a call-time pass-by-reference is prohibited since php 5.4
    2499 | ERROR | Using a call-time pass-by-reference is prohibited since php 5.4
    2505 | ERROR | Using a call-time pass-by-reference is prohibited since php 5.4
    —————————————————————————————

    https://www.ads-software.com/plugins/php-compatibility-checker/

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Contributor Jason Stallings

    (@octalmage)

    Hi MiKemp! Thanks for trying the plugin.

    The library we’re using to detect incompatible code just reads your plugins/themes to find issues. This isn’t as accurate as executing the code, and it looks like this is a false positive. It’s been reported here:

    https://github.com/wimg/PHPCompatibility/issues/68

    In most situations I would side with the plugin/theme developer as far a compatibility goes, especially with Jetpack.

    Please let me know if you have any other questions!

    Thread Starter MiKemp

    (@mikemp)

    Thank you for the quick reply. Not meaning to seem dense here, and remember this isn’t my territory, but if, as you said “In most situations I would side with the plugin/theme developer as far a compatibility goes…” when would I know the plugin results are accurate?

    Plugin Contributor Jason Stallings

    (@octalmage)

    A passing result should be a compatible plugin. The library we use tends to be on the aggressive side, favoring false positives over no results at all. This way you have something to look into. Some will be able to look at the results and determine if the code is incompatible or not, and if you’re not very familiar with PHP you can either bring the results to us or to the plugin developer and they’ll be able to confirm!

    As we continue to work on this the results will get more accurate, and I started a list to hopefully help with the false positives:

    https://github.com/wpengine/phpcompat/wiki/Results

    I hope this answers your question!

    Thread Starter MiKemp

    (@mikemp)

    Great answer, thanks.

    Plugin Contributor Jason Stallings

    (@octalmage)

    No problem! I’m going to mark this as resolved!

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘A little surprised at results, Jetpack, for example fails 5.4’ is closed to new replies.