Access-Control-Allow-Credentials being sent out as numbers not strings

  • Resolved joeylamprecht

    (@joeylamprecht)


    6 months, 4 weeks ago

    Dear development team!

    I have found an issue with the plugin. The value for the Access-Control-Allow-Credentials is being sent out as 1 instead of true. This happens because of a bug in src/Helpers/Headers.php. The value

    $option->is_allow_credentials()

    is being concatenated with the rest of the header which cause php to convert it to 1 or 0. A revised version of this line could be:

    if ( $option->is_allow_credentials() ) {
    header( 'Access-Control-Allow-Credentials: ' . ($option->is_allow_credentials() ? 'true' : 'false') );
}

    After updating the code, the plugin started working as intended.

    If you use Github for version control, I would be happy to create a pull request. If you need any other information feel free to reach out to me.

    Kind regards,
    Sebastian Joey Lamprecht

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author Dev Kabir

    (@devkabir)

    Dear Sebastian Joey Lamprecht,

    Thank you for bringing this issue to our attention. We appreciate your thorough investigation and proposed solution regarding the Access-Control-Allow-Credentials header in our plugin.

    We want to assure you that this issue has been previously reported, and we have added this to our to-do list. Your detailed findings will undoubtedly contribute to resolving it effectively.

    If you have any further questions or require additional information, please don’t hesitate to contact us. Your input is valuable to us as we strive to improve our plugin.

    Thank you once again for your diligence and cooperation.

    Plugin Author Dev Kabir

    (@devkabir)

    Since we haven’t received a response from you, I’m proceeding to close this thread. Please know that you’re welcome to contribute to this thread at any time by adding your message.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Access-Control-Allow-Credentials being sent out as numbers not strings’ is closed to new replies.

Tags