ACF fix

  • Resolved Elliot Condon

    (@elliotcondon)


    11 years, 11 months ago

    Hi Marko

    Loving the plugin. I’m using it on a clients site and I realy like your interface for creating the tabs.

    To integrate with ACF, I had to edit your css/tabs.css: line 23 and change

    .tabifybox-hide { display: none; }

    to
    #poststuff .tabifybox-hide { display: none; }

    This hides the acf postboxes on first load.

    Just an idea. Instead of using jquery to hide / show, I would use classes to do the same thing, but your classes can then use the !important rule to override other plugins display. This will give you better compatibility.

    Cheers
    Elliot

    https://www.ads-software.com/extend/plugins/tabify-edit-screen/

Viewing 8 replies - 1 through 8 (of 8 total)
  • Plugin Author Marko Heijnen

    (@markoheijnen)

    The reason that I used javascript there was that it only is needed when javascript is enabled. Obviously you can use the .js CSS class for that.

    For me it’s really important that my plugin works as best as possible without javascript. So I will look into this improvements this month ??

    Thread Starter Elliot Condon

    (@elliotcondon)

    Hi

    I think you mY have misunderstood me. Definitely use javascript but think Bout using javascript to add / remove classes instead of using hide / show functions.

    That way, your css classes can use the !important attribute and override ACF.

    Plugin Author Marko Heijnen

    (@markoheijnen)

    Ah okay that way. Did misunderstood that. But is this only a problem on load or also on switching tabs? Hopefully I got some time next week to play and fix it

    Thread Starter Elliot Condon

    (@elliotcondon)

    Only a problem on load.

    ACF has css to show / hide the metaboxes and unfortunately the css gets a higher priority than yours. So on load, all the acf metaboxes are shown.

    But with the fix above (which won’t ruin anything), it works 100% with ACF.

    Also, it might be nice to place the tabs underneath the post title input field. As that field is always present, it might be good to take it out of the tab content area.

    Plugin Author Marko Heijnen

    (@markoheijnen)

    Thanks for the info.

    The placing of tabs is not going to change. I had it under the title before but changed it because for me above it makes more sense how it is right now since it gets the extra width from the right column. Did however create a ticket that it should be changeable through a filter.

    Thread Starter Elliot Condon

    (@elliotcondon)

    Nice, a filter would be great.

    Good work all round mate.

    Plugin Author Marko Heijnen

    (@markoheijnen)

    Been working today for this fixes and way more: https://github.com/markoheijnen/tabify-edit-screen.

    Will be releasing an update tomorrow. First need to check all edge cases really well before ending up with a javascript error again.

    Plugin Author Marko Heijnen

    (@markoheijnen)

    Just released version 0.5 with all your demands ??

Viewing 8 replies - 1 through 8 (of 8 total)
  • The topic ‘ACF fix’ is closed to new replies.