Activate alert message not being injected w/ Buddypress 2.2

Are you talking about on the frontend where it says “Your membership account is awaiting approval by the site administrator. You will not be able to fully interact with the social aspects of this website until your account is approved. Once approved or denied you will receive an email notice.” ?

Yes. That’s the one. Its also used in the profiles when they try to access bbpress or bp. Its showing up in those cases. Just not when the user activates the account.

I’ll have to check on it and see if I can reproduce. I admittedly didn’t do much testing for 2.2.0 with this plugin, but I can’t imagine anything that changed that’d prevent it.

That’s what I thought to. I’m just waiting for a spare moment to dig into it.

They changed the activation url. That’s the problem. Your isset( $_GET[‘key’] ) fails so the message isn’t injected.

Refactor member activation URL to better avoid email spam filters. New URL looks like this – example.com/activate/XXX. The older URL format – example.com/activate/?key=XXX – is still supported for backward compatibility. (#5831)

Ahh…good catch, and something I should have remembered as I was attentive of general BP dev for 2.2. *Slaps forehead*

At least it’s a pretty easy fix.

https://github.com/WebDevStudios/BuddyPress-Registration-Options/issues/82

Hi there Michael, I’m working with @sharmstr.

You mention above it’s an easy fix, is this now fixed please? It’s just that my new members are currently either getting no message at all or 3 confusing messages when they activate their email.

Many thanks

Mark

What are the “3 confusing messages”?

The only time this param is used is in the following:

if ( isset( $_GET['key'] ) || bp_registration_get_moderation_status( $user ) ) {
	if ( $moderate ) {
		$activate_message = stripslashes( get_option( 'bprwg_activate_message' ) );
		echo '<div id="message" class="error"><p>' . $activate_message . '</p></div>';
	}
}

and the message should show if the key GET param is set OR they’re already marked as in moderation. The only time the key GET param gets set is when they’re clicking the activation link from their email, at least regarding BuddyPress 2.1 and lower. So it should only be an an affected case the moment after they’ve activated their account. Once they navigate to a new area, the message should kick in again for 2.2 users.

Regardless, I’ll see about working on getting this patched this week.

Hi Michael, apologies I didn’t get an email notification to say you’d replied.

Here’s the screenshots and background info: https://seventhqueen.com/support/forums/topic/changing-messaging-correctly-and-where-to-find

Or you can view this screenshot here which shows the 3 messages: https://www.diigo.com/item/image/55mss/dbyu?size=o

I’ll switch the notifications on now!

Many thanks
Mark

I know the first one comes from BuddyPress. Are the 2 after that from custom messages in your settings?

I believe so. To be clear I only want the bottom one in ready to appear.

From what I can recall and from reading through our source code, we only display one message in that type of fashion, and it’s the first textarea from your BP Registration Options settings page. If any of those are from our plugin specifically, it’ll match what’s in that first textarea. However, that still leaves one unaccounted for.