Add icons

  • Resolved Awya

    (@awya)


    12 years ago

    Hi there!

    Thank you very much for the plugin, really making things easier ^^

    I just had issues with the “add icon” functionnality (though it’s really cool you added it):
    When I create or edit a custom post type, there’s an “add icon” button (of course you know, YOU put it there ^^), but when clicked, nothing happens.
    Threw a (quick and naive) eye on the problem and console showed an error in add-edit.js line 12:

    file_frame = wp.media.frames.file_frame = wp.media({
<strong>Uncaught TypeError: Cannot read property 'frames' of undefined (repeated 5 times)</strong>
			title: 'Add Icon',

    I’m no expert, especially with js but I think it might be the first line’s

    function($)

    that should be replaced with

    jQuery(document).ready(function($)

    And of course, I don’t forget the “)” at the end of the script

    Thing is… I tried, and although the error goes away, the “add icon” button still doesn’t work :/

    Then… How can I say? … Help !! ??

    Anyway, thanks a lot for your work !!! ^^

    https://www.ads-software.com/extend/plugins/custom-post-type-maker/

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Author Jorn Bakhuys

    (@jornbakhuys)

    Hi Awya,

    Thanks for noticing this bug. Somehow the plugin worked in my testing environment, but on another testing environment it doesn’t work, just like you described.

    I know how to fix this bug but another bug appeared right after, so I need to fix that too before I will bring out a new update.

    Thanks again.

    And for your reference, function($) is a self invoking function, so it will run just like jQuery(document).ready(function($) does.

    Thread Starter Awya

    (@awya)

    Hi again Jorn

    Wow, thanks for the quick reaction ??
    No problem, take your time, I shall wait for your next release,
    Good luck with your new bug

    And thank YOU, I did nothing more that clic a button ^^

    PS: Oh ok, thank you for enlightening my ignorance. As said, I just noticed this in console and got curious

    Plugin Author Jorn Bakhuys

    (@jornbakhuys)

    Hi Awya,

    I have fixed the bug you noticed and also fixed the bug that I encountered.
    An update of the plugin is being uploaded right now, so whenever you see an update available, go hit that update button. ??

    Thanks again for noticing. Please let me know if this fixes your problems.

    Thread Starter Awya

    (@awya)

    Hi Jorn !

    Once again, impressed by your quick response.
    Yeah, just saw and hit update button and everything works fine ??

    Thanks again for your plugin, your work and your availability !!!

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Add icons’ is closed to new replies.