slots casino real money.Claim Your Free 999 Pesos Bonus Today

Resolved Viktor Bijlenga
(@viktorbijlenga)

5 years, 5 months ago
Thanks for a great plugin!

Would it be possible to add the textdomain passwordless-login to the login button, located in passwordless_login.php:191? This would make it a lot easier to translate the button correct.

The code probably should look like this:

<input type="submit" name="wpa-submit" id="wpa-submit" class="button-primary" value="<?php esc_attr_e( 'Log In', 'passwordless-login' ); ?>" />

I can submit a patch at Bitbucket, if it would make things easier.
- This topic was modified 5 years, 5 months ago by Viktor Bijlenga.

Viewing 10 replies - 1 through 10 (of 10 total)

Gabriel Berzescu
(@gabrielberzescu)

5 years, 5 months ago

Hi Viktor,

Thanks, I am forwarding this to our development team.

Cheers,
Gabriel

Thread Starter Viktor Bijlenga
(@viktorbijlenga)

5 years, 5 months ago

Thanks! Would it be possible to release a fix for the bug this week?

Gabriel Berzescu
(@gabrielberzescu)

5 years, 5 months ago

Hi there,

At the moment this looks quite unlikely… There is very high load on development, and the issue can not have a very high priority.

Best of regards,
Gabriel

Thread Starter Viktor Bijlenga
(@viktorbijlenga)

5 years, 5 months ago

Ok! I’ve created a fork with the patch over at Github, while we wait at this getting fixed. https://github.com/imwithfriends/passwordless-login

Please notify me if this fix is released.

Gabriel Berzescu
(@gabrielberzescu)

5 years, 5 months ago

All right then, I have asked the development team to notify me when this gets fixed, and then I will notify you here.

Best regards,

Thread Starter Viktor Bijlenga
(@viktorbijlenga)

5 years, 4 months ago

Thanks Gabriel! Sounds great. Let me know if I can help in any way.

Gabriel Berzescu
(@gabrielberzescu)

5 years, 4 months ago

All right then Viktor, glad to help ??

Gabriel Berzescu
(@gabrielberzescu)

5 years, 4 months ago

Hi there, this has finally been fixed! ??

Thread Starter Viktor Bijlenga
(@viktorbijlenga)

5 years, 4 months ago

Thanks Gabriel + the team.

PS. If you ever decide to move the project to Github. Let me know. If would make it a lot easier to contribute with small fixes and improvements as pull requests.

Github Actions makes syncing to SVN easier. This is a good read.
https://wptavern.com/10up-releases-github-actions-for-simplifying-wordpress-plugin-deployment

Gabriel Berzescu
(@gabrielberzescu)

5 years, 3 months ago

All right Viktor, thanks for the idea. We’ll make sure to let you know if we move the project to Github.

Best of regards,
Gabriel

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘Add textdomain to login button’ is closed to new replies.