add_submenu_page being called without parent_slug

  • Resolved eclev91

    (@eclev91)


    1 month, 4 weeks ago

    Perhaps this falls under PHP 8.2 deprecation notices, but the PayPal gateway (and probably others) are trying to add a submenu item without a parent item. Regardless of deprecations this ends up throwing, this simply isn’t how this function is supposed to be used.

    If I replace null with the tec-tickets menu item slug, I get the expected link, but wind up on a 404 page. So I’m not sure what’s trying to be accomplished here.

    We don’t even have PayPal set up as a payment gateway at this time. It’s possible we once did, but we do not at this time. The Payments settings page, under the PayPal tab, shows our connection is not set up. So really, I don’t see why any of this code should be running at all.

    FWIW:

    • Tribe__Tickets__Commerce__PayPal__Handler__IPN::get_config_status() returns 'complete'
    • tribe_get_option( 'ticket-paypal-enable', false ) returns true
    • TEC\Tickets\Commerce\Gateways\PayPal\Merchant::is_connected() returns false
    • This topic was modified 1 month, 4 weeks ago by eclev91.
Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Support tristan083

    (@tristan083)

    Hi @eclev91 ,

    Thank you for reaching out and bringing this to our attention.

    To better understand the situation, could you provide us with the detailed steps you are taking (to get the error or notice) and the full error (or notice) log that’s being thrown here? Are there any unexpected behavior on the user interface that’s attributed by this function (or code)?

    Thread Starter eclev91

    (@eclev91)

    Deprecated: strpos(): Passing null to parameter #1 ($haystack) of type string is deprecated in .../wp-includes/functions.php on line 7300
    Call Stack
    #	Time	Memory	Function	Location
    1	0.0010	408416	{main}( )	.../index.php:0
    2	0.0012	445136	require_once( '...wp-admin/admin.php )	.../index.php:10
    3	0.3560	37487320	require( '...wp-admin/menu.php )	.../admin.php:158
    4	0.8579	40405536	require_once( '...wp-admin/includes/menu.php )	.../menu.php:412
    5	0.8596	40444528	do_action( $hook_name = 'admin_menu', ...$arg = variadic('') )	.../menu.php:161
    6	0.8596	40444744	WP_Hook->do_action( $args = [0 => ''] )	.../plugin.php:517
    7	0.8596	40444744	WP_Hook->apply_filters( $value = '', $args = [0 => ''] )	.../class-wp-hook.php:348
    8	0.8623	40567392	Tribe__Tickets__Commerce__PayPal__Orders__Report->register_orders_page( '' )	.../class-wp-hook.php:324
    9	0.8623	40567640	add_submenu_page( $parent_slug = NULL, $page_title = 'PayPal Orders', $menu_title = 'PayPal Orders', $capability = 'edit_posts', $menu_slug = 'tpp-orders', $callback = [0 => class Tribe__Tickets__Commerce__PayPal__Orders__Report { public $orders_page = NULL; public $orders_table = NULL }, 1 => 'orders_page_inside'], $position = ??? )	.../Report.php:163
    10	0.8623	40567640	plugin_basename( $file = NULL )	.../plugin.php:1478
    11	0.8623	40567640	wp_normalize_path( $path = NULL )	.../plugin.php:769
    12	0.8623	40567640	wp_is_stream( $path = NULL )	.../functions.php:2182
    13	0.8623	40567640	strpos( $haystack = NULL, $needle = '://' )	.../functions.php:7300

    This is me copying and pasting the XDebug output. But I’ve linked the line in your source code that is problematic. Regardless of whether or not WordPress gracefully handles what comes next (see above – it does not), you’re calling add_submenu_page in an unexpected and unintended way.

    Plugin Support tristan083

    (@tristan083)

    Hi @eclev91 ,

    Thank you for your message and the information.

    I have logged an internal bug ticket for this, and I added your case. Thanks for all the details. I will definitely pass it along to our devs.

    I am unable to provide an exact date or time estimate for when this bug will be fixed, but you’ll be notified when there are any updates.

    If you do have other concerns or issues you need help with, please create another thread, as it helps us track different issues.

    —

    Internal Bug Ticket Reference: TECTRIA-425

    Plugin Support Darian

    (@d0153)

    Hi there,

    It appears that there hasn’t been any recent activity on this thread, so we’ll consider it resolved. However, if you have any additional questions or concerns, feel free to start a new thread.

Viewing 4 replies - 1 through 4 (of 4 total)
  • You must be logged in to reply to this topic.