Adding Screen Options in custom menu pages no longer works

I don’t quite understand your question.
That code was added in the last release, in changeset https://core.trac.www.ads-software.com/changeset/47957
for ticket https://core.trac.www.ads-software.com/changeset/47951
and the previous generic filter says “Only applied to options ending with ‘_page’, or the ‘layout_columns’ option”.

If you have a test case of where this is not working correctly, please comment on the ticket and @ mention the committer.

I guess to make your code work for both versions of WP, you have to put the function on both filters.

Thanks for the reply.

I used same function for both of the filters and its working.

But my question is if my options ends with ‘_page’ then whats the need of second filter?

It’s new, so I guess it’s for options that don’t end in _page.
If your filter is not checking for false, then it doesn’t hurt if it runs twice.

This seems like a strange change that was made to the code, and hard for people like you to make your code work on both versions.

Someone pointed out this ticket: https://core.trac.www.ads-software.com/ticket/50392

Yes, I found that.

Thanks for your time and giving me such appreciating supports.