Additional filtering for the Translation Filter

  • Resolved cognoquest

    (@cognoquest)


    8 years, 10 months ago

    Hello Roland I think I found a few areas that requires the use of the translation filter:

    The Dropdown/Other Form Element optgroup label is not being parsed by the translation filter, pdb version: 1.6.2.7.1 line 1485 in xnau_FormElement.class.php

    Replace:
    $divider .= sprintf('<optgroup label="%s">', $title);
For:
    $divider .= sprintf('<optgroup label="%s">', Participants_Db::set_filter('translate_string', stripslashes($title)));

    The other option ‘$otherlabel’ for the Dropdown/Other Form Element at line 1191 in xnau_FormElement.class.php could also be parsed via i18n

    if ( $otherlabel !== false ) $this->_addline( '<option ' . ( $this->value !== '' ? $this->_set_selected( $this->options, $this->value, 'selected', false ) : '' ) . ' value="other" >'.$otherlabel.'</option>' );

    I am not sure how we get an update to you for the french .po locale files? Not to complicated: ‘other’ => ‘autre’ for the above code.

    One last item, I am a little confused by the method used to translate the helptext in edit_participant.php line 215

    <span class="helptext"><?php _e(stripslashes(trim($column->help_text))) ?></span>

    Should it not be parsed by the translation filter like the rest of the dynamic data?

    Note: Sorry I have not updated to the latest pdb version so I can only provide information for pdb version: 1.6.2.7.1

    https://www.ads-software.com/plugins/participants-database/

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Author xnau webdesign

    (@xnau)

    Thanks for finding these issues…it’s hard to find every little string and make sure they get internationalized. These 3 strings are not properly treated, I’m adding this to the bug list.

    The POT file will need to be rebuilt for that, then it can be included in the translation file, so for now you can use your own solution.

    Thread Starter cognoquest

    (@cognoquest)

    Your welcome.

    it’s hard to find every little string and make sure they get internationalized.

    I completely understand and you have my gratitude.

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Additional filtering for the Translation Filter’ is closed to new replies.