Adds a unique identifier to Google Fonts

  • Resolved DaanvandenBergh

    (@daanvandenbergh)


    2 years, 2 months ago

    Hi guys,

    I’m the developer of OMGF and a client just ran into a compatibility issue with your plugin, so I thought I’d notify you of my findings.

    You’re adding unique identifiers to the id attribute, which is used by plugins, like OMGF and Autoptimize’s Critical CSS addon, to identify stylesheets and check if they need to be optimized. But since you’re generating random unique identifiers on each pageload (it seems?), these plugins will continue to optimize these stylesheets, eventually crashing the site.

    Some examples:

    • ?sp-wpcp-google-fonts6320b9a0e2512
    • ?sp-wpcp-google-fonts6320b9a283b1e

    I’ve fixed the issue in OMGF, but I suggest you remove the unique identifiers from the id attribute, since it’s a misuse of the id attribute’s purpose and because more (CSS optimization) plugins might use the id attribute for similar purposes.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Plugin Support Pulak Ahmed

    (@pulak00)

    Hi @daanvandenbergh,

    Thanks for pointing out the issue. After doing some research we have decided not to use the unique identifier in future versions of the plugin. Instead, we will use an ID based on the shortcode ID and which will resolve the issue.

    Thanks for reaching us and we highly appreciate that.

    • This reply was modified 2 years, 2 months ago by Pulak Ahmed.
    Thread Starter DaanvandenBergh

    (@daanvandenbergh)

    Awesome! ??

    We’re here to help eachother, right? ??

    kudo’s to both of you from yet another plugin developer! ??

    Thread Starter DaanvandenBergh

    (@daanvandenbergh)

    Ok, who flashed the Frank signal up in the sky?

    Ride your Frankmobile back to your Frankcave, Frank. The crisis has been avoided. Your superpowers are no longer needed here. ??

    (Seriously, though, how do you always know when someone mentions your name?)

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Adds a unique identifier to Google Fonts’ is closed to new replies.