Advanced Heading Issues

1. No issues with heading https://monosnap.com/file/gy9yZ901Ra6Hqq0IrDQDmthWyjwsjQ

On your video, I see that you have set zero line height for your headings. Check settings of typography in theme (or in greenshift) or your custom code for headings. Proper heading must have proper height https://monosnap.com/file/hkw8dhsYWzekSU9WL0DSymvl2aI9md

Letter merging and margin – again, because you have line height as zero somewhere in settings for your headings. Plugin inherit theme’s settings if you don’t set it in plugin. If you send link, I can tell you place where you set zero line height

Agh, yes you are right about the line height, thanks for clarifying. I did set that to 0 in the theme settings.

There is still a big space (margin) above the Advanced Header, when I place a block above it. https://www.awesomescreenshot.com/image/33441360?key=9a3a0dd3e9e73ee97cfd07d50833bd2d

I notice that Blocksy is creating that spacing under their “Entry Content > Content Spacing” settings. If I set it to None, the spacing disappears https://www.awesomescreenshot.com/image/33441435?key=a08d42da76c3d2d12af4a88cbb752de8

Is this a Blocksy issue? It was not doing that before for me when I had everything set as default in the theme, the spacing issue only started happening after the latest Greenshift updates, hence why I am bringing it up.

Thanks again for you help.

• This reply was modified 2 years, 4 months ago by paulluxford.

Unfortunately, the previous logic was a bug, now, plugin follows spacing which is set in theme. I don’t know why Blocksy added this spacing above headings. Please, ask support of theme and let me know reason

What I can do – is only add option to have Spacing option more priority. It’s added now. You can set 0 spacing for margin in heading and it will have more priority over theme’s spacing

Legendary! Thank you very much for that update.

I’ll reach out to Blocksy and bring it their attention. They are generally very good to respond with compatibilities, so I’ll let you know the outcome.

Thanks again!

Hi again. I reached out to Blocksy support and they responded with the following:

—
Actually, this isn’t really an issue. Every WordPress theme has some defaults for their elements and in this case, Blocksy has some too. All you should do is set a margin-top to zero for that specific heading if you don’t want it.

Alternatively, you can use a little bit of CSS to remove those margins globally, but that will affect all headings. Something like this perhaps —

.entry-content *+:is(h1,h2,h3,h4,h5,h6) {
margin-top: 0 !important;
}

But again, modifying the Greenshift block using its settings should do the trick, as this is the expected default behaviour for Gutenberg blocks.

—

The CSS option looks to be the way to go for global heading spacing.

• This reply was modified 2 years, 4 months ago by paulluxford.
• This reply was modified 2 years, 4 months ago by paulluxford.
• This reply was modified 2 years, 4 months ago by paulluxford.

Yes, I agree with them. It’s expected, but it’s not clear why you didn’t have spacing before. So, you used not heading block (maybe text block) or set 0 margin to top in block settings

Before the recent update to Greenshift (4.0), whenever I added the Advanced Heading block, I would add 0 margin top and bottom in block settings, which would remove the spacing.

The update (4.0), removed the priority of 0 top and bottom margin and assigned that to the theme, hence why I could not reduce the spacing unless in the theme settings.

Now that you have added the priority back again, it works as before.

But is it ideal? Is that how it is supposed to work? I don’t know, I am just used to a certain way of doing things and when changes happen I think it is broken, maybe it’s me and I need to change what I am doing, maybe I am not doing things correctly (user error).

When I look at the core WP Heading block, it does not have any settings for margins and even Kadence Advanced Heading block also needs to have 0 top and bottom margin settings applied to look correct (based on my tests with the Blocksy theme).

I appreciate your help with this.

Yes, it’s correct work. Headings must have margins to divide it from content. We prefer to use bottom margin, but many themes use top and bottom

Thank you for confirming that is the correct method and again, I appreciate your time with this one.