AMP issues caused by function in your plugin, proposal on how to resolve

  • Resolved milan.latinovic

    (@milanlatinovic)


    5 years ago

    Hi everyone,

    We were dealing with some AMP issues on our web site.

    Type of issue:
    – External stylesheets not supported, except for whitelisted font providers. Use the document inline ‘style amp-custom’ tag instead.

    Screenshot: https://ibb.co/4ZXjPnN

    These issues are caused by external stylesheet <link> element. After some debugging we found out that this link was created by one function in your plugin, under a comment “Adding FontAwesome/Dashicons at the header for AMP.”

    AMP does not support adding external stylesheets like this, so this function will cause Google SEO Console and AMP validator to complain.

    Once we commented out this function directly in your plugin problems were resolved.

    Side-note: This function will as well cause the AMP issue “Disallowed attribute or attribute value present in HTML tag.”, with the same cause.

    Having this in mind, could you please remove or refactor this function in your next releases?

    Screenshot: https://ibb.co/27L76nX

    If you need any assistance from my side please let me know. This fix will be needed by anyone who uses your plugin in combination with AMP pages.

    Hopefully this makes sense.

    Kind regards,
    Milan

    The page I need help with: [log in to see the link]

Viewing 2 replies - 1 through 2 (of 2 total)
  • Plugin Contributor contactashish13

    (@rozroz)

    @milanlatinovic thanks for pointing this out. We have already scheduled this fix for the next release. Keep an eye out for it! ??

    Thread Starter milan.latinovic

    (@milanlatinovic)

    Great, thanks!
    If I notice any more possible improvements what is the best way to become a contributor?
    To create a ticket with fix description as I did, or to write directly to repository? I find ticket with explanation a bit better.

    Kind regards,
    Milan

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘AMP issues caused by function in your plugin, proposal on how to resolve’ is closed to new replies.