Gambling sites with welcome bonus,bet999.ph login.REGISTER NOW GET FREE 888 PESOS REWARDS!

Resolved austinnovelty
(@austinnovelty)

5 years, 10 months ago

The WP AMP Plugin’s AMP HTML syntax is valid, but the url generation seems to cause issues.

https://amp.dev/documentation/guides-and-tutorials/learn/amp-caches-and-cors/amp-cache-debugging?format=websites recommends the tool https://ampbench.appspot.com/ which says the AMP URL does not pass the test. https://ampbench.appspot.com/validate?url=https%3A%2F%2Fwww.history101.com%2Fvikingfacts%2F%3Famp

AMPbench seems to fail on the querystring ‘?amp’ as far as I can tell. There isn’t much in terms of documentation on the expected URL structure but using ‘?amp’ causes issues with purging caches.

The first issue I ran into was when I attempted to purge the amp cache. I had to use the work around listed in:
https://github.com/ampproject/amphtml/issues/10883

Which worked fine for Google’s amp cache but not cloudflare or bing.

If you look at any mainstream site that has amp implemented, they us either a subdomain, directory in the path, or some combination of the two. Your implementation is the first i’ve seen that uses a query string.

Due to lack of documentation or official specification in regards to the AMP URL structure, I can see how this issue occurred. One can argue that the issue is with the AMP Cache code, but why go against the examples in their docs?

My concern here is that other tools/services related to AMP may fail here.

The page I need help with: [log in to see the link]

Viewing 8 replies - 1 through 8 (of 8 total)

Plugin Author Alberto Medina
(@albertomedina)

5 years, 10 months ago

That is an issue with AMP Bench. If you use the AMP validator service, or the Chrome extension everything is good:

https://validator.ampproject.org/#url=https%3A%2F%2Fwww.history101.com%2Fvikingfacts%2F%3Famp

Plugin Author Alberto Medina
(@albertomedina)

5 years, 10 months ago

An issue should be filed on AMP Bench.

Thread Starter austinnovelty
(@austinnovelty)

5 years, 10 months ago

Does the Validator link you posted check Syntax only? or does it actually inspect the url?

Thread Starter austinnovelty
(@austinnovelty)

5 years, 10 months ago

I asked because the github page clearly says AMP HTML Validator. https://github.com/ampproject/amphtml/blob/master/validator/README.md

It does not mention that it checks the URL of the site as far as I have seen.

Plugin Author Weston Ruter
(@westonruter)

5 years, 10 months ago

It’s not clear why that ?amp URL fails the AMP URL test in AMP Bench.

This one does not fail: https://make.xwp.co/2019/03/15/7-experiences-that-create-team/?amp

See results: https://ampbench.appspot.com/validate?url=https%3A%2F%2Fmake.xwp.co%2F2019%2F03%2F15%2F7-experiences-that-create-team%2F%3Famp

The URL should not matter, whether it uses query arg or a path endpoint.

I’ve opened an issue on AMP Bench where you can follow for a resolution: https://github.com/ampproject/ampbench/issues/113

Plugin Author Pascal Birchler
(@swissspidy)

5 years, 10 months ago

Hi @austinnovelty

I think the issue is that the “AMP URL” label is misleading. This is not validating the format of the URL, but actually checks whether that page is valid AMP.

The “FAIL” comes from the AMP validation output that you can see when scrolling down on https://ampbench.appspot.com/validate?url=https%3A%2F%2Fwww.history101.com%2Fvikingfacts%2F%3Famp:

tl;dr your site is not valid AMP at the moment.

Plugin Author Weston Ruter
(@westonruter)

5 years, 10 months ago

@swissspidy But the validator says it is valid: https://validator.ampproject.org/#url=https%3A%2F%2Fwww.history101.com%2Fvikingfacts%2F%3Famp

Thread Starter austinnovelty
(@austinnovelty)

5 years, 10 months ago

So I didnt get a chance to reply (because weekend).

I’ve had issues when attempting to clear cache.

With Bing/Cloudflare I can purge the amp url with a uri encoded querystring ‘%3famp’ or ‘%3Famp’.
With google’s amp cache I have to use the upper case version or I get errors returned. I am also able to add the ‘amp’ parameter after the amp_ts parameter when attempting to ‘purge’ a url from google’s cache. With the latter I only have to reorder the querystring no encoding. This method did not work with Bing/Cloudflare however.

So while the ampbench tool may need a fix, it seems that each cache purge behaviour is different as well.

Again, I am not saying ‘?amp’ isn’t correct to implement, It does seem to expose issues with other AMP service functionality.

Viewing 8 replies - 1 through 8 (of 8 total)

The topic ‘‘?amp’ querystring vs /amp/ in path’ is closed to new replies.

Tags