• Resolved janiosarmento

    (@janiosarmento)


    Is this plugin AMP compatible?

    The last time I tried I had to give up the plugin because it inserted scripts in the published pages that broke the AMP validation.

Viewing 8 replies - 16 through 23 (of 23 total)
  • Hi @isaumya .

    I checked it on my local environment and it seems the issue has been fixed.

    Thread Starter janiosarmento

    (@janiosarmento)

    So, I’ve decided not to include our scripts on AMP pages as they were getting stripped out by the AMP system anyway but by doing this the admin side validation errors will not occur anymore.

    This is good enough.

    I’m going to download the fix and give it a try, but since it’s working time now, I’ll take longer to do that.

    Thank you very much for fixing that!

    Plugin Contributor iSaumya

    (@isaumya)

    No problem, test when you can. If you enjoy it please do share a review. ??

    Thread Starter janiosarmento

    (@janiosarmento)

    I just checked the fix you provided. Everything seems fine, but the option to clear CF page in Dashboard disappeared.

    A minor annoyance, but if it could be brought back in wp-admin context, it would be superb.

    Thread Starter janiosarmento

    (@janiosarmento)

    Also, after the fix the plugin interface does not work anymore.

    screen-recording-2021-03-14.mov

    I’ve cleaned all caches, including Cloudflare and browser, but it does not work.

    Plugin Contributor iSaumya

    (@isaumya)

    Hi @janiosarmento,
    I’m unable to reproduce what you have shown in the screen recording. As on my end the admin side works perfectly. Please check the browser console of something is showing there.

    Cause the patch does not remove the scripts from the admin side but only from the AMP pages.

    Moreover, if you are taking about bringing back the purge cache option on the top admin bar when viewing an AMP pages, that’s not possible cause on AMP pages the scripts don’t work to purge pages. But it will show up on everywhere except AMP pages.

    Thread Starter janiosarmento

    (@janiosarmento)

    In such a case, I’ll wait for the next release of the plugin. I think it’s safer than dealing with patches, and due to the end of the fiscal year I’ll be under big pressure for the next two weeks.

    Thanks for your great work!

    Plugin Contributor iSaumya

    (@isaumya)

    Hi @janiosarmento,
    Here is a screencast to show you and others who might stumble onto this thread, later on, the plugin in action after the above patch in place: https://www.screencast.com/t/vmASxheQ9k

Viewing 8 replies - 16 through 23 (of 23 total)
  • The topic ‘AMP support’ is closed to new replies.