apostrophes show up incorrectly in email subjects

  • I started a forum topic with the word “Here’s” in the title. The subject of the email notification, however, had it as Here & # 0 3 9 ; s — but without the spaces in between those characters. Basically it seems that you are escaping them with htmlentities() or something, but maybe you shouldn’t do that for the subject line of an email.

    This was in Gmail.

Viewing 4 replies - 1 through 4 (of 4 total)
  • Thread Starter hran

    (@hran)

    I figured out why. It’s because you’re relying on the default behavior of html_entity_decode(), which doesn’t touch single quotes. I’m not sure if there is a reason for that, but if not, you can fix this by specifying the mode as ENT_QUOTES.

    See here: https://us.php.net/manual/en/function.html-entity-decode.php

    EDIT: And indeed, adding ENT_QUOTES to those functions in the plugin fixed the problem for me.

    Plugin Contributor Dwenaus

    (@dwenaus)

    hey @hran thanks for this helpful bug report. can you paste a code example of your fix so your change won’t get lost in the next upgrade. and if possible a diff file (they are pretty easy to make)

    Thread Starter hran

    (@hran)

    Hey @dwenaus, thanks for fixing this in the newest version! Sorry I didn’t get you that diff in time, but it looks like you managed to fix it (I grep’ed the new code).

    Plugin Contributor Dwenaus

    (@dwenaus)

    actually, I think it was boone that fixed that one.

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘apostrophes show up incorrectly in email subjects’ is closed to new replies.

Tags