• Resolved tharnendil

    (@marekmierzwa)


    Hi,

    After the recent update to WP 5.3.1, when I add a new meeting:

    1. fill the name and location
    2. select “Part of the group”
    3. fill the group information
    4. select “Apply group to location” checkbox
    5. publish the meeting

    the following error appears in the browser (/wp-admin/post.php):

    `
    Warning: Invalid argument supplied for foreach() in /wp-content/plugins/12-step-meeting-list/includes/save.php on line 328

    Warning: Cannot modify header information – headers already sent by (output started at /wp-content/plugins/12-step-meeting-list/includes/save.php:328) in /wp-admin/post.php on line 223

    Warning: Cannot modify header information – headers already sent by (output started at /wp-content/plugins/12-step-meeting-list/includes/save.php:328) in /wp-includes/pluggable.php on line 1265

    Warning: Cannot modify header information – headers already sent by (output started at /wp-content/plugins/12-step-meeting-list/includes/save.php:328) in /wp-includes/pluggable.php on line 1268
    `

    The new meeting is added but without any group information.

    I didn’t use this checkbox until today, so I cannot be sure that the issue was causd by the upgrade.

    Best wishes,
    Marek

Viewing 6 replies - 1 through 6 (of 6 total)
  • Plugin Author tech2serve

    (@tech2serve)

    Hi @marekmierzwa,

    With the information I have, I was unable to reproduce the error you’re seeing.

    Please tell me what theme you’re using. And whether you’ve made any modifications to it.

    Also, please tell me what version of the 12-step-meeting-list plugin you have installed.

    You also may want to try disabling other plugins you have installed and see if you continue to get the error.

    Thread Starter tharnendil

    (@marekmierzwa)

    Hi @tech2serve,

    I deactivated two suspected plugins (“Restrict user access” and “Adminimize”) but the behavior is still the same.

    I customized the functions.php file as follows (customizing translations, adding new meeting attribute, etc.): https://gist.github.com/TheGreenSourcerer/bb950843724b82aee45bf590f99b6e2e

    and the single-meeting.php template file (to hide the group e-mail and phone number because of the potential GDPR-related law issues in EU):
    https://gist.github.com/TheGreenSourcerer/fa0e58b4bdc09deec465c747768159a1

    A new observation – after the first error (on meeting entry creation) I opened the meeting details and tried to fill the group details again with the “apply group to location” option checked. On the second save (update actually) the details were saved normally. So it looks like only the first publish is affected.

    Cheers,
    Marek

    • This reply was modified 5 years, 2 months ago by tharnendil.
    Plugin Author tech2serve

    (@tech2serve)

    Hi Marek,

    Even taking the gists you provided, I’ve been unable reproduce the errors you’re getting.

    My suggestion, if possible, is to roll back the changes you’ve made to default code of 12-step-meeting-list and one-page-meeting-list, and see if you can get the errors to disappear.

    As far as keeping group contact information private, did you try setting the Meeting/Group Contacts to Private?

    Thread Starter tharnendil

    (@marekmierzwa)

    Hi @tech2serve,

    Sorry for the late response. I cannot roll back all the changes since this would lead to revealing the personal data that cannot be publicly shown without proper consent (the meetings data is managed by multiple servants and I cannot guarantee if they gather the consents).

    The setting you refer to is set to keep this data private, but the group phone number/e-mail is still displayed when it’s filled. Only the contacts were hidden. That’s why I had to modify the original template.

    Plugin Author tech2serve

    (@tech2serve)

    Hi @marekmierzwa,

    Correct, Group phone/email is displayed because the expectation is that groups would have that information public so they can be reached.

    Individual contacts (i.e., Person with their phone/email) is kept private unless you explicitly make it public.

    If you want to manage Group phone/email information privately, then I suggest using the Contact lines for that information when it needs to be kept private. You don’t even have to fill out the Name field, just the phone/email. Above that, you only fill out the information you can allow to be publicly seen.

    Thread Starter tharnendil

    (@marekmierzwa)

    Correct, Group phone/email is displayed because the expectation is that groups would have that information public so they can be reached.

    Yes, I understand the reasoning behind this decision. Unfortunately, as I mentioned, it’s not that simple in EU (because of GDPR) in cases, where this data can be filled by many people that don’t understand or even care about the compliance with the law ??

    Anyway, even though the problem with error (invalid argument supplied...), I think the users can live with that if it’s not reproducible in other environments.

    Thank you for all your time!

    • This reply was modified 5 years, 1 month ago by tharnendil.
Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘“Apply group to location” crashes on save’ is closed to new replies.