as_has_wp_comment_logs loading

  • Resolved peter8nss

    (@peter8nss)


    3 months, 2 weeks ago

    I’m tuning my page load performance. I’ve noticed that on every page there is an individual call to get_option for as_has_wp_comment_logs – rather than this option being loaded as part of wp_load_alloptions.

    The call originates from the plugins_loaded hook as follows:

    get_option()
    wp-includes/option.php:197
    ActionScheduler_WPCommentCleaner::has_logs()
    wp-content/plugins/wp-mail-smtp/vendor/woocommerce/action-scheduler/classes/ActionScheduler_WPCommentCleaner.php:61
    ActionScheduler::init()
    wp-content/plugins/wp-mail-smtp/vendor/woocommerce/action-scheduler/classes/abstracts/ActionScheduler.php:209
    action_scheduler_initialize_3_dot_7_dot_4()
    wp-content/plugins/wp-mail-smtp/vendor/woocommerce/action-scheduler/action-scheduler.php:60
    ActionScheduler_Versions::initialize_latest_version()
    wp-content/plugins/wp-mail-smtp/vendor/woocommerce/action-scheduler/classes/ActionScheduler_Versions.php:59

    I think the problem is that, by default, there is no entry in the database options table for as_has_wp_comment_logs so it cannot be autoloaded. If there was an entry in the options table for as_has_wp_comment_logs with value “no” and autoload=yes, I think that would improve page load performance for most people using your plugin.

Viewing 7 replies - 1 through 7 (of 7 total)

  • I checked the query time for a specific option request from the database in one of my environments, and the query time was less than 0.0005 seconds. Trying to tune queries that fast is excessive and unnecessary. Is it an unnecessary call that could be optimized? Sure. But it won’t improve your site’s performance by any meaningful metric. If the query takes longer than 0.01 seconds, then there’s likely an infrastructure problem that needs to be addressed.

    @peter8nss How much time does that query take in your environment?

    • This reply was modified 3 months, 2 weeks ago by crstauf.
    Thread Starter peter8nss

    (@peter8nss)

    You are correct that 0.0005s is not going to make much difference, but you won’t be surprised to know that your plugin is not the only one that has “unnecessary” get_option calls. And its starts adding up.

    I can appreciate that, though 200+ queries (at 0.0005 seconds per) does sound suspicious. I’ll plan to submit a PR today, but it will be up to the maintainers to accept it, and they’re a small team with other priorities (so I’ve been told).

    This filter may be helpful in the meantime, or with the other plugins: https://developer.www.ads-software.com/reference/hooks/wp_default_autoload_value/.

    Thread Starter peter8nss

    (@peter8nss)

    Don’t think that filter is relevant as it is affects setting the autoload value when writing to the database. Whereas this topic is about entries that have never been written to the database.

    Simpler workaround is just to add the option once through the CLI:

    wp option add as_has_wp_comment_logs no

    For your reported situation it won’t, you are correct, but possibly for the other plugins that are running queries for single options.

    Submitted PR:
    https://github.com/woocommerce/action-scheduler/pull/1086

    @peter8nss Coupled with your WP-CLI command, the following callback on the delete_option_option action will ensure the option is always populated:

    add_action( 'delete_option_as_has_wp_comment_logs', static function ( $option ) {
    	update_option( 'as_has_wp_comment_logs', 'no' );
    } );
    • This reply was modified 3 months, 2 weeks ago by crstauf.
Viewing 7 replies - 1 through 7 (of 7 total)
  • You must be logged in to reply to this topic.