• Resolved craigsnydervector

    (@craigsnydervector)


    We use the plugin to enable the autocompletion dropdown for the search. We want to set up event tracking (Algolia has some of that built-in), but it indicates we need version 1.12 or greater of autocomplete.js.

    As far as I can tell, the version in the plugin is 0.38.1 (i’m looking in the dist folder in the plugin). Is this correct? What will happen if we update to the latest and greatest? Or is the a recommended/suggested version that will work with the plugin? We currently have v2.8.1 of the plugin

    Thanks

    The page I need help with: [log in to see the link]

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Contributor Michael Beckwith

    (@tw2113)

    The BenchPresser

    Hi there,

    Yes, out of box we still have version 0.38.x as the default. We have yet to either figure out an easy way to seamlessly upgrade everyone, or just accept the proverbial bandaid needing ripped off.

    I know we have this branch https://github.com/WebDevStudios/wp-search-with-algolia/tree/feature/272-autocomplete-upgrade where we started working offering a version picker, but it does need a refresh from the looks of things.

    We have this open issue with deeper discussion as well https://github.com/WebDevStudios/wp-search-with-algolia/issues/232

    For example, the biggest hurdle is that we won’t be able to automatically attach ourselves to a given theme’s search field. This is because of this change from Autocomplete:

    <!-- Autocomplete v0.x -->
    <input id="autocomplete" />
    
    <!-- Autocomplete v1.x -->
    <div id="autocomplete"></div>

    For example we presently target the search field with this selector:

    input[name='s']:not(.no-autocomplete):not(#adminbar-search)

    Based on how WordPress search works, that name selector is pretty ubiquitous.

    Once upgraded, each site owner is going to need to drop in <div id="autocomplete"></div> spot themselves, as well as take care of any new styling issues that come from this HTML markup change.

    Thread Starter craigsnydervector

    (@craigsnydervector)

    OK. Thanks for the links and details. Definitely helpful. Seems there is more time we will need to work on this for our site.

    Plugin Contributor Michael Beckwith

    (@tw2113)

    The BenchPresser

    We also need to return to working on getting that branch ready as a feature, to be honest. I know there’s a good amount of clamoring for the new Autocomplete because of details like analytics and event tracking.

    Thread Starter craigsnydervector

    (@craigsnydervector)

    Can you put us on your list for testing/early notice? Thanks

    Plugin Contributor Michael Beckwith

    (@tw2113)

    The BenchPresser

    We don’t really have a great setup at the moment for reaching out to people manually, so the best thing to do would be to keep an eye on the repo itself on GitHub, and most specifically this PR:

    https://github.com/WebDevStudios/wp-search-with-algolia/pull/370

    Admittedly as well, I’m curious how well the current PR would work, as is, outside of some potential needs to run some composer and npm commands. I know we’ve had a handful of releases since then for the .org copy of file structure, but none of those are touching autocomplete things either. Just some thoughts.

Viewing 5 replies - 1 through 5 (of 5 total)
  • You must be logged in to reply to this topic.