Awesome Plugin! A few bugs (and fixes)

  • Hi there. Nice work on this little plugin.

    Seriously, it was exactly what I was looking for! Simple. Easy for my clients to use. Hard for my clients to screw up. I’ve been wanting something like this for a long time now. I’m definitely going to be using this one on many of my custom sites in the future.

    However, I noticed a couple of bugs that you’ll want to fix:

    1.) I get the following error message when I try to insert an instance of the button: Notice: Undefined index: full_width in /Users/evanscheingross/Sites/paws/wp-content/plugins/lbdesign-button-shortcode/lbdesign-button-shortcode.php on line 23

    FYI – I’m working locally on a new site and wp_debug turned on. Users who set this to false won’t see this error.

    I checked your source code and it looks like you have a check for an array key ‘full_width’ which is never set or initiated. Removing that check (lines 23-27 of lbdesign-button-shortcode.php) will do the trick.

    2.) The little button icon doesn’t show up for me in my instance of tinyMCE. The button is there and it works, but the background image of the tiny link icon doesn’t appear because the URL path is incorrect.

    On line 15 of lbdesign-button-shortcode.js change

    image : '/wp-content/plugins/lbdesign-button-shortcode/img/icon-grey.png'

    to

    image : './../wp-content/plugins/lbdesign-button-shortcode/img/icon-grey.png'

    That will do the trick.

    If you can get these updates pushed out I’d love to come back and give you a 5-star rating on the plugin.

    Keep up the good work!

    https://www.ads-software.com/plugins/lbdesign-button-shortcode/

Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter Evan Scheingross

    (@evster)

    Regarding #1 mentioned above, you’ll also need to strip out the $full_width variable on line 40 of lbdesign-button-shortcode.php

    Unless of course you want to finish coding in the option for the user to set whether or not the button will display at full width (which would actually be a nice option if you ask me).

    Thread Starter Evan Scheingross

    (@evster)

    One final thing… Might be a good idea to change the shortcode to something more unique than [button] to eliminate the chance of a conflict with another active plugin trying to utilize the same exact shortcode.

    Plugin Author Lauren Pittenger

    (@lepittenger)

    Hi @evster! Thanks so much for such detailed feedback! I’m going to aim to get the issues you pointed out by the end of this week. Thanks so much again.

    Thread Starter Evan Scheingross

    (@evster)

    Hey just a quick update…

    This little plugin is really useful and I’m using on several sites now.

    Regarding issue #2 I had mentioned in my original post, I see you have updated line 15 of lbdesign-button-shortcode.js to
    image : '../../wp-content/plugins/lbdesign-button-shortcode/img/icon-grey.png'

    However when I am developing locally it delivers an incorrect URL for that icon, so it doesn’t appear for me to click on. Changing that line to

    image : './../wp-content/plugins/lbdesign-button-shortcode/img/icon-grey.png'

    works for me regardless of the URL at which the website is running. (Note the single . at the beginning of the URL instead of the double ..)

    Thanks!

    Plugin Author Lauren Pittenger

    (@lepittenger)

    Hey Evan, thanks for flagging that up to me. I pushed up a fix, let me know if you run into any other issues!

    Thread Starter Evan Scheingross

    (@evster)

    You rock! Just updated the plugin on a local site I’m working on and so far, so good. Will let you know if I notice any bugs that crop up.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Awesome Plugin! A few bugs (and fixes)’ is closed to new replies.