"Bad practice"

  • Hi,

    Great plugin, in general. But I detected a bit of ‘bad practice — so to speak — with regard to the hardcoded “$twitter_username” bit. The setting is available on the options page to change it, but renders itself useless seeing as it’s hardcoded.
    Sure, only takes one second or two to change in the source itself – but why offer it as a setting when it can’t be changed?

    But it’s a good plugin, though ??

    Keep it up.

Viewing 6 replies - 1 through 6 (of 6 total)

  • why give it a 1 star for just that!?

    Thread Starter k0nsl

    (@k0nsl)

    Well, one reason is that I don’t like bad practice. Maybe it was just a clumsy fault by the developer, or maybe it wasn’t.
    I do get your point. It is very possible that I was a bit too harsh!

    Faithfully,
    Kuensl

    You can always adjust the number of stars you gave to the plugin. ??

    Thread Starter k0nsl

    (@k0nsl)

    I’ve adjusted it to three stars :]

    -k0nsl

    Plugin Author Tom Morton

    (@tm3909)

    k0nsl,

    Appreciate you catching this! A feature that didn’t get fully implemented.

    I’ll get an update up ASAP. Obviously it wasn’t intended to work like this.

    I’ll update this thread when its fixed.

    -Tom

    Plugin Author Tom Morton

    (@tm3909)

    Quick update: Version 2.1 has the twitter username populating properly. It was just pushed up and can be found in the plugin trunk or give it a few and your WordPress plugins page will show an update.

    Hope this works for what you need and thanks again for using WPSocialite.

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘"Bad practice"’ is closed to new replies.