• Resolved albert0346

    (@albert0346)


    Hi,

    I use the Storefront and Boutique Client Themes and “Our Bank Details” is not translated to German.

    How can I get it translated with the Hyyan WooCommerce Polylang Integration plugin?

    Thanks for your help.

    Albert

    • This topic was modified 7 years, 8 months ago by albert0346.
Viewing 7 replies - 1 through 7 (of 7 total)
  • Plugin Contributor jomo

    (@jonathanmoorebcsorg)

    Hi,
    You haven’t stated which Payment Gateway or exact field you are referring to, but in general terms:

    Built-in strings should be translated using the .po/.mo language files for that plugin
    Strings which are configurable in admin should be translated via the Polylang strings translation table.

    This plugin registers the following strings for translation in the Polylang Strings translation table:
    – title
    – description
    – instructions
    see: public function registerGatewayStringsForTranslation()

    See:
    https://github.com/hyyan/woo-poly-integration/wiki/Translation-Overview
    and links on this page for further information.

    Thread Starter albert0346

    (@albert0346)

    Thanks jonmoore!

    Regarding this “Our Bank Details”:

    It’s the text which appears at the thank you page for a German customer after purchasing with direct bank transfer. There is no possibility to translate it in the strings translation table.

    But I have additional problems:

    . There is the string “Customer matched zone “Deutschland”” on the cash page, where “Customer matched zone” is also not translated.

    . When I choose the English language I get on the cash page in “Your order” the text which you can see in the attached file. There are {/term_link} and {/revocation_link} which should NOT appear here. And when you click on “revocation provision” I come to the GERMAN and not to the ENGLISH page.

    . The English language customer gets on his buying reception email the revocation text in GERMAN and not in the ENGLISH language.

    I don’t know if the above problems are also connected somehow to my also installed plugin “WooCommerce Germanized”, which I didn’t mention in my first post.

    And finally to another problem which is not related to this, but perhaps you know an answer to this:

    When you check out the field for the delivery address is activated. But most people want the products to be delivered at the living address. Is there a solution that this field is deactivated?

    OK, here you have a lot of questions. But I hope you have time to answer them. Again, thanks a lot for your help in advance.

    Albert

    Thread Starter albert0346

    (@albert0346)

    I forgot that you can not send an attachment with wordpress. So here is the image:

    Screen capture

    Albert

    • This reply was modified 7 years, 8 months ago by albert0346.
    Plugin Contributor jomo

    (@jonathanmoorebcsorg)

    WooCommerce Germanized have recently made some enhancements to support Polylang integration, also adding some filters to Hyyan WooCommerce Polylang Integration 1.0.2 to support additional translations so I suggest you check with them.

    These may not be released yet as they may require version 1.0.2 of this plugin, which you can also get from: https://github.com/hyyan/woo-poly-integration/tree/1.0.2

    Please note that:
    – officially there is no support on these forums, as per the pinned post
    – Hyyan WooCommerce Polylang Integration is a non-commercial product supported by unpaid volunteers in their spare time, in any.

    I’ll close this from here as should be followed up with WooCommerce Germanized plugin instead.

    Hi,
    same issue here.
    @albert, did you solve this problem?
    Bank Details are translated in mo/po language files, but translation disappears as soon as I activate Woo Poly Integration plugin :/

    I cannot install version 1.0.2 which jonmoore reecomennded… white page appears after activating plugin version 1.0.2.

    I think I got it!
    I replaced the text domains in the file GatewayBACS.php from ‘woocommerce’ to ‘woo-poly-integration’ and synced the .pot and updated the .po file – now it works like charm!

    Maybe this issue should be changed in the next update!

    Plugin Contributor jomo

    (@jonathanmoorebcsorg)

    The idea would be to use the wooCommerce translations when available.

    for example:
    GatewayBACS.php function bank_details is a simply copy of WC_Gateway_BACS.bank_details as indicated by the commments, since the function was private in wooCommerce it had to be copied.

    * Note: Since this is declared as a private function in WC_Gateway_BACS, it needs
    * to be copied here 1:1

    In wooCommmerce3 version there are some minor changes like:
    Woo3: __( ‘Our bank details’, ‘woocommerce’ )
    woo-poly: __(‘Our Bank Details’, ‘woocommerce’)
    so in this case the woo-poly code isn’t picking up the woocommerce translation as the phrase has changed.

    So the solution for the current implementation should be simply to copy the bank_details function again from class-wc-gateway-bacs.php in woocommerce to GatewayBACS to replicate the new standard woocommerce behaviour.

    The ideal solution though would be to not copy the function, get WooCommerce to change their WC_Gateway_BACS.bank_details function from private to protected so it is accessible.

    Please would you try that and report results on https://github.com/hyyan/woo-poly-integration/issues/217
    (I didn’t write and don’t use this functionality)

Viewing 7 replies - 1 through 7 (of 7 total)
  • The topic ‘“Our Bank Details” is not translated to German’ is closed to new replies.