Beta tests results

Hello Nicolas, and first many thanks for all your hard work on direct-stripe !

I install direct-stripe beta 3.0.0 on a test site, but I have the same problem already notified here : https://www.ads-software.com/support/topic/sca-ready/

–> include of includes/ds-modal.php from line 34 of controllers/class-ds-button.php give warning, because the file doesn’t exist on includes folder.. and so the button don’t work on front-end. Maybe it’s just an oversight during the build ?

Didn’t have time to look further into it now, but hope this could help. And can’t wait to see my payment gateway working with the ‘4000000000003220’ stripe test card ??

Thanks for your support

Alexis

• This reply was modified 5 years, 6 months ago by scaphandroid.
• This reply was modified 5 years, 6 months ago by scaphandroid.
• This reply was modified 5 years, 6 months ago by scaphandroid.

Hello @scaphandroid ,

Thank you for using Direct Stripe and reporting the issue, this was caused by untracked files from git that weren’t added to svn… Sorry about that, I pushed them and you should be able to test the new modal form and process 3d secure cards, –hopefully– ??

Kind regards,

Hello Nicolas,

Thanks for fixing the beta files. I gived a try today, the error caused by the missing include is gone.

But there’s other problems when testing with stripe’s 3d secure test card (4000000000003220) :

– after clicking ‘Payer’ on the new modal form, it get stuck with the loading icon.. and do nothing else
– using my browser’s debugger, I saw a request to admin-ajax.php with the payment token and button parameters giving a 500 response code
– the modal form didn’t show the stripe’s 3d secure test modal, which is showed for instance when using woocommerce payment gateway with this test card
– when using the test card 42424242.. without 3d secure, everything is working fine, and the same request give a 200 response code
– when using the 3d secure test card, even if the payment is logged as ‘incomplete’ into Stripe dashboard and the modal form is stuck as said above, the action ‘direct_stripe_before_success_redirection’ is triggered..

(I have tested this using a payment gateway which is a bit specific, using the success action to send emails, and add meta to the user. But I also tried on a blank page with a simple button, all the actions deactivated, and it give the same errors when using the 3d secure test card)

I remain available if you want additional information, and try to find a solution together!

Kind regards,

Hello @scaphandroid ,

Thank you for testing again,

Could you details what you mean by ” the action ‘direct_stripe_before_success_redirection’ is triggered ” ?

Could you also share the message logged in Stripe for the incomplete payments please ? At Developer -> logs and Developer -> Events, do you see any error ?

EDIT : Could you also share the browser you are testing with ? And try with anther one ?

Kind regards,

• This reply was modified 5 years, 6 months ago by Nicolas Figueira.

Hello @nahuelmahe

I’m testing with Firefox, last version – on ubuntu 18.04 – and just did another try with Chrome 76, with the same result.

There’s no error on Stripe’s log : the last call to Stripe API is /v1/payment_intents , and the response given by Stripe is quite the same given to a no 3D secure cart transaction, except there’s no ‘charge’ object returned by the API – because the payment is no complete.

About the action direct_stripe_before_success_redirection : this action is on ds_process_functions.php , I hook on this to do custom stuff when a payment is sucessfull. With the beta I noticed these actions are done even if the payment is not sucessfull – because it’s logged as uncomplete by Stripe – so I assume the action ‘direct_stripe_before_success_redirection’ should not be called in this case ?

Kind regard,

Are you using the new PaymentIntents with this beta version, or does the v2 already use PaymentIntents?

Hello,

Thank you for the feedback @scaphandroid. Could you test the plugin without any hook called and let me know if that works as expected ?

Then we can start looking for issues caused by hooks or with the hooks.

@jsherk this beta uses the PamentIntents API, not 2.1.* versions

Kindly,

Hello @nahuelmahe

I made new tests:
???– on the site already tested, with all hooks disabled, and even with all other plugins disabled and the default wordpress theme instead of my custom theme
??– on another site where I use direct stripe (without turning off anything)
??– on a new wordpress installation, with just direct stripe installed

In all cases the result is the same: if the test card 424242 .. without 3D secure seems to work well, the 4000000000003220 test card does not work!

As stated in my previous messages it is always a 500 error that is returned by admin-ajax.php when the request with the payment token is tranmitted. On the side of stripe it is payments are marked ‘incomplete’ but in the logs wordpress direct stripe they are marked “capturés”!

These errors are very worrying to a few days of fateful delay .. do you plan a correction for this beta or should we use another payment system?

I hope we can find a solution!

Regards,

Hello @nahuelmahe ,

I took a little time to try to understand the 500 error, here’s what I noticed:

– Error 500 is returned by line 559 of ds_process_function.php (http_response_code (500);)
– this means that we did not enter any of the previous conditions in the function “ds_generatePaymentResponse”
– I dumped $ intent before the conditional blocks of this function, and noticed, in the case of a single payment, that $intent->status = “requires_source_action”
– the condition in this single payment case seems to be “if ($ intent-> status ===” requires_action “…”, so that’s why we never enter the condition, replacing it with “requires_source_action” the payment button is functional with the card 4000000000003220 and presents the Stripe 3d secure test !
– I noticed in Stripe’s API documention, that since the version 2019-02-11 “requires_source_action is now requires_action”, so because $intent->status=”require_source_action” it seems to say that your plugin uses the 2017 version of the API, is this normal ? I think there is something to dig to fix these bugs …

Hope this will help you finalize this beta

Regards

Hello @scaphandroid ,

Thank you very much for the feedback.
Because of the date I pushed the beta to the repository.
I made changes based on your feedback, and avoided the precise status check that seemed the cause trouble in your case ( and probably would have for many others ).

This is still a beta as there is a lot to cover.

Let me know how the update goes !

Kind regards,

Tried various error situations – seems many not handled (not showing anything, gif just keeps spinning)..

Enter bad card: 4000000000003220

400/Bad Request  https://api.stripe.com/v1/payment_methods
Response: {"error": {"code": "card_declined",
"doc_url": "https://stripe.com/docs/error-codes/card-declined",
"message": "Your card was declined. Your request was in live mode, but used a known test card.", "param": "", "type": "invalid_request_error"}}

=> should show some error messages to user..
—
– top line too low in fieldset – maybe add:
.ds-element.in-form fieldset legend{top: -8px;}
—

Hello @megamurmulis ,

Thank you for reporting these exception messages issues.

Definitely adding it to the queue to goboutbof beta.

Kind regards

Hi Nicolas,

First of all, thanks for taking the time to update the plugin for SCA. It’s really appreciated.

I have installed the beta and in most browsers the modal loads successfully. In Brave, which is Chrome-based but with enhanced privacy/security features, the Stripe element fields are blocked by default but this is not an issue on your side.

However, after filling out the test details, I get an infinite spinner without any console errors to debug. Tested in Chrome, Safari and FireFox with all other plugins disabled and the default card number 4242424242424242 (so not the 4000… yet) but cannot seem to get it to work.

Any idea why this could be?

Best wishes,

P.S. Nothing is registered in Stripe itself when carrying out the payment with the new beta. Settings like API keys etc. are the same as before.

• This reply was modified 5 years, 5 months ago by d1pl0macy.
• This reply was modified 5 years, 5 months ago by d1pl0macy.

Hi Nicolas,

I’ve installed 3.0 beta today after trying it in a test installation where everything worked well.

After installing it on my website the button is there without function and the modal form is already to be seen.

Checked all the settings and everything is as it should be.

I can send you the link to the page or a screen shot.

Kind regards,
Tom

Hi @nahuelmahe,

Thanks for updating the plugin to the new API.

I’ve encountered a CSS issue when testing it in my sandbox:

I’ve fixed it in my theme, but because the class success is very likely to be used by themes ( as well as error, it might be a good idea to set more strict and detailed rules.

In the example above I had to set .ds-element .success { background: transparent; border: none; }.

Merci !

• This reply was modified 5 years, 5 months ago by Marc Lacroix.