Jili 9889 real money,Jili777 com ph withdrawal.Recharge Every day and Get Bonus up-to 50%!

Resolved morris4ever69
(@morris4ever69)

5 years, 6 months ago
In WC v3.6.3, in the file woocommerce/includes/class-wc-countries.php, between lines 622-626 there is:
```
if ( 'optional' === get_option( 'woocommerce_checkout_address_2_field', 'optional' ) ) {
    $address_2_placeholder = __( 'Apartment, suite, unit etc.', 'woocommerce' );
} else {
    $address_2_placeholder = __( 'Apartment, suite, unit etc.', 'woocommerce' );
}
```
The result is a double “optional” string in the label when the field is not required. Something like:

Apartment, suite, unit etc. (optional) (optional)

The second “(optional)” string comes from a span tag:

<span class="optional">(optional)</span>

added to not required fields.

Why there is the if statement in the class-wc-countries.php file?
- This topic was modified 5 years, 6 months ago by morris4ever69.
- This topic was modified 5 years, 6 months ago by morris4ever69.

Viewing 4 replies - 1 through 4 (of 4 total)

Plugin Support RK a11n
(@riaanknoetze)

5 years, 6 months ago

Hi there,

The second “(optional)” string comes from a span tag:

Would you mind sharing where in the core WooCommerce code you’re seeing that? I’m asking as the file at https://github.com/woocommerce/woocommerce/blob/master/includes/class-wc-countries.php doesn’t include that extra span tag anywhere?

Moreover, are you sure that duplicate optional text isn’t coming from a template override instead?

Thread Starter morris4ever69
(@morris4ever69)

5 years, 6 months ago

I’m sorry, the code in my first post came out from a test and I removed the “optionl” string in the if statement.

By the way, at line 624 of:

https://github.com/woocommerce/woocommerce/blob/17da960abe6dadd63d0301d2412145197f5353c6/includes/class-wc-countries.php#L624

there is:

$address_2_placeholder = __( 'Apartment, suite, unit etc. (optional)', 'woocommerce' );

Before updating to WC 3.6.3 I had not the problem of doubled “(optionl)” so probably you are right, I may changed something in the template override. I will investigate there. Thanks.

Thread Starter morris4ever69
(@morris4ever69)

5 years, 6 months ago

Little update: I marked as resolved but I think it’s not. ??

The second “(optional)” string in the span tag comes from the file wc-template-functions.php, on line 2628:

https://github.com/woocommerce/woocommerce/blob/17da960abe6dadd63d0301d2412145197f5353c6/includes/wc-template-functions.php#L2628

So, why there is the “(optional)” here:

https://github.com/woocommerce/woocommerce/blob/17da960abe6dadd63d0301d2412145197f5353c6/includes/class-wc-countries.php#L624

if this string should be added by the instruction in wc-template-functions.php file?

Thanks.

Plugin Support RK a11n
(@riaanknoetze)

5 years, 6 months ago

Looks like you might have discovered a bug there – Would you mind creating a bug report for our developers to look into that? The direct place for that bug report is over at https://github.com/woocommerce/woocommerce/issues

Viewing 4 replies - 1 through 4 (of 4 total)

The topic ‘Billing address 2 label: double “optional” string’ is closed to new replies.