Book titles with apostrophes break images
-
David,
Thank you for a lovely, useful plug-in! I found one small issue that I thought I’d share here…
Using the plug-in, I’ve found that books with apostrophes in their titles don’t show up. For instance, this one:
https://www.goodreads.com/book/show/31409135
It looks like somehow the apostrophe is causing the link tag attributes to break. I fixed it in my copy by adding:
str_replace('\'', '’', $reading->book->title)
… in the appropriate places. Here’s the full replacement code section:
// CURRENTLY READING foreach ($reading->reviews->review as $reading) { $title = str_replace('\'', '’', $reading->book->title); if (!$img = $this->goodrds_image_exceptions($reading->book->id)) $img = $reading->book->image_url; $return .= "<a target='_Blank' href='https://www.goodreads.com/book/show/{$reading->book->id}' title='{$title} - #{$reading->book->id}' class='book reading' style='background-image:url({$img});'></a>"; $showbooks--; } // RECENTLY READ #->id #->book->id #->book->title #->book->average_rating #->book->authors->author->name foreach ($read->reviews->review as $read) { if ($showbooks > 0) { $title = str_replace('\'', '’', $read->book->title); if (!$img = $this->goodrds_image_exceptions($read->book->id)) $img = $read->book->image_url; $return .= "<a target='_Blank' href='https://www.goodreads.com/book/show/{$read->book->id}' title='{$title} - #{$read->book->id}' class='book read' style='background-image:url({$img});'></a>"; $showbooks--; } }
Please consider adding something like this fix in a future version.
Thanks again!
Viewing 2 replies - 1 through 2 (of 2 total)
Viewing 2 replies - 1 through 2 (of 2 total)
- The topic ‘Book titles with apostrophes break images’ is closed to new replies.