broken footer edits in 2011 child theme since update to wordpress 3.5

  • Resolved 5high

    (@5high)


    11 years, 10 months ago

    Hi,

    I’ve been working on a 2011 child theme for a few months now, and all was fine until the upgrade to the new wordpress 3.5 version.

    For some reason it doesn’t allow my child edits of the Footer area (colophon) to take effect, despite going overboard with putting !important by everything. All other edits seem to be holding, but I can’t see any change in code, so can’t work out how to make it take effect.

    I’ve deactivated all my plugins, have no cacheing plugins, cleared page caches etc and have re-loaded the 3.5 update – all without effect. My only other thought was that it could be related to the 2011 theme update, though I don’t think it happened then – but i will try to find an older version and check with that too.

    My child theme uses the 2011 ‘light’ theme as this seemed to cause fewer issues than the dark theme, and my current 2011 Child theme Footer edits are:-

    /* to change background colour of main footer
*/
#supplementary {
	background-color: #141414 !important;
	border-top-color: #141414 !important;
    border-top-style: solid !important;
    border-top-width: 1px !important;
	border-top-left-radius !important: 12px;
	border-top-right-radius !important: 12px;

}
/* to reduce text size and font-weight of Powered by WordPress link
*/
#site-generator {
	background-color: #0C0C0C !important;
	border-top-color: #0364a1 !important;
	border-top-width: 2px !important;
	border-bottom-left-radius: 12px !important;
	border-bottom-right-radius: 12px !important;
	font-size: 10px !important;
	font-weight: lighter !important;
	padding-bottom: 15px !important;
	padding-top: 0px !important;
}
#supplementary.three {
	padding-bottom: 0.5em !important;
}
/* to change text alignment in footer widgets:
*/
#first .textwidget {
	text-align: left !important;
	color: #ffffff !important;
}
#second .textwidget {
	text-align: center !important;
	color: #ffffff !important;
}
#third .textwidget {
	text-align: right !important;
	color: #ffffff !important;
}

    and a link to a page is https://trevorpenfold.com/about-tp/ though all other pages are private, as it’s not fully ready to be uploaded.

    I would really appreciate any ideas, and I will also post back with an update re: using an older version of thew 2011 theme.

    Cheers.

Viewing 9 replies - 1 through 9 (of 9 total)
  • Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    Your CSS looks like it’s working to me, what makes you think it isn’t?

    Thread Starter 5high

    (@5high)

    Hi Andrew,

    The footer as a whole was edited to become much narrower, and the ‘site-generator’ bit should be black with rounded bottom corners.

    Thanks.

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    I suspect there’s a syntax error in your Child Theme stylesheet that is causing your Child Theme’s styles from a certain point to be unrecognised.

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    Look at the errors generated by W3C’s CSS validator (for your Child Theme stylesheet) and ignore the CSS3 errors. The first error looks important.

    Thread Starter 5high

    (@5high)

    Hi Andrew,

    Thanks for the link – really helpful and I’ll have to try and work out how to use it myself!

    I’ve changed the first Child theme error, namely

    75 body, input, textarea Value Error : font-weight 550 is not a font-weight value : 550

    so that the value is now 500, which seemed to be a valid option. but still no change…

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    Don’t worry about it, I don’t think there’s a syntax error after looking through your errors more thoroughly, in relation to your actual code.

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    Actually there is something spooky going on here. You can add your styles to the top of your stylesheet (still below the @import) and they should work.

    Andrew Nevins

    (@anevins)

    WCLDN 2018 Contributor | Volunteer support

    This style here;

    .DOP_WallGridGallery_Lightbox img {
	border-bottom-left-radius: 0px !important;
	border-bottom-right-radius: 0px !important;
	border-top-left-radius: 0px !important;
	border-top-right-radius: 0px !important;

    In your Child Theme has the syntax error (not closed off curly brace).
    You should now remove your !important styles before they screw you over in the future.

    I am surprised that the CSS validator didn’t pick this up. I suppose it may have something to do with the CSS3 styles in the stylesheet confusing it.

    Thread Starter 5high

    (@5high)

    Hi Andrew,

    Yes – it worked! just by inserting the missing ‘}’ as you found fixed all of the Footer issues! I don’t quite understand why, but I’m very pleased! Thank you.

    Just one query – you said

    You should now remove your !important styles before they screw you over in the future.

    …does that mean for as much as possible in the child theme?
    And how do they mess it up if some are left in?

    Many thanks.

Viewing 9 replies - 1 through 9 (of 9 total)
  • The topic ‘broken footer edits in 2011 child theme since update to wordpress 3.5’ is closed to new replies.