Broken link behavior and strange JavaScript

  • Resolved Stegosource

    (@stegosource)


    4 years ago

    Hi, I noticed a bug being caused by this plugin. By default, a browser will allow users to press the CTRL key when clicking on a link, and it will open that link in a new tab. However, when I had this plugin installed, I noticed that this feature no longer worked.

    Checking the event listeners on my links, I found this code:

    
function fe(e) {
  Y();
  var t, n = this,
    r = n.href,
    o = n.action,
    u = r || o,
    s = z(n.method || i);
  i === s && H(n) && (t = new URLSearchParams(new FormData(n)) + "", u = U(u.split(/[?&#]/)[0]) + (t ? "?" + t : "")), x[u] = [V(n, s, u), n], $(e)
}

    It was coming from this source:
    https://cdn.statically.io/gh/taufik-nurrohman/f3h/v1.0.12/f3h.min.js

    As it turns out, this feature is part of the Statically plugin, enabled under the “Page Booster” settings.

    The f3h library calls itself “progressively enhanced”, but in this case it actually breaks a feature of the web. I imagine it’s something the author would be willing to fix.

    I’m also reporting on their GitHub, so hopefully it can be fixed, but figured I would mention it here as well.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Plugin Author Frans Allen

    (@fransallen)

    Hi @stegosource,

    Thanks for contacting us.

    You can set Pagebooster manually (with custom javascript) in the setting, make sure you have the Developer Mode enabled. Check the docs here https://taufik-nurrohman.js.org/f3h/

    In case something doesn’t work you can add the javascript source to the “Scripts to refresh” option.

    Since this is experimental, I suggest you check out the docs. But we will keep trying to make it even more stable for general use.

    Cheers,
    Frans

    Thread Starter Stegosource

    (@stegosource)

    Yeah, it’s not a major issue, but I wanted to report it nonetheless. The fix was a pretty minor thing, and it seems like the library author has already fixed it. Not sure if it’s published yet, or when it’ll be available in this plugin. I just wanted to bring it to attention.

    Plugin Author Frans Allen

    (@fransallen)

    Thank you so much @stegosource for your concern, this topic is useful. We’ll keep an eye on this and let you know when there’s an update ??

    Please, how did you fix it?

    Thread Starter Stegosource

    (@stegosource)

    @twibe this is not something an end user can fix. It’s something the original library author will have to fix. I just disabled the feature.

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘Broken link behavior and strange JavaScript’ is closed to new replies.