Broken on Update

  • Resolved Joshua David Nelson

    (@joshuadnelson)


    6 years, 10 months ago

    Hello,

    It looks like you’ve removed the return $output; from the main shortcode function. This is resulting in the video background not working on the front end of our site.

    I’m guessing others in the forum recently having issues are a result of this as well.

    Thanks,
    Joshua

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author pushlabs

    (@pushlabs)

    Hi Joshua,

    Thanks for being a Video Background user!

    Instead of returning the $output, Video Background now uses wp_add_inline_script() to add the plugin init. This is the recommended way to add an inline script through WordPress. As a result, this should not be an issue. Perhaps it could be a different problem? If you’d be willing to share a URL I could take a closer look ??

    Blake

    Thread Starter Joshua David Nelson

    (@joshuadnelson)

    Blake,

    Thanks for the response!

    I only noticed it because of the update and just thought it was an error. However, upon digging into a bit more I realized that in our case we’re moving the vidbg scripts around to accommodate other things, so that might be why we needed the return.

    Thanks again,
    Joshua

    Plugin Author pushlabs

    (@pushlabs)

    Hi Joshua,

    I am glad that you found a solution!

    I will be adding a helper filter that will allow you to modify Video Background’s script dependencies so it may be easier for cases where there may be a conflict with another plugin or library; this may help as it sounds like this may have been happening. This filter should be out in the next version ?? You’ll be able to find documentation on it here:

    https://pushlabs.co/docs/video-background/

    Have a great day!

    Blake

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Broken on Update’ is closed to new replies.