broken protocol-relative url detection

  • Resolved Maik Penz

    (@goatherd)


    10 years, 7 months ago

    Protocol relative URLs use // not ://. Adjusting this as in the diff below fixed compatibility with plugins using CDN for script includes (i.e. use-google-libraries and various caching plugins).

    Previously those scripts had to be explicitely deactivated through bwp-minify backend.

    wp-content/plugins/bwp-minify/includes/class-bwp-minify.php
@@ -554,7 +554,7 @@ if (!empty($page))
        function is_local($src = '')
        {
                // Add support for protocol-relative urls
-               if (false === strpos($src, '://') && substr($src, 0, 1) != '/') {
+               if (false === strpos($src, '//') && substr($src, 0, 1) != '/') {
                        $src = 'https://'. $src;
                }
                $url = @parse_url($src);

    https://www.ads-software.com/plugins/bwp-minify/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Thread Starter Maik Penz

    (@goatherd)

    well, not sure the change above does fix the issue, it only made a message disappear for local testing and cloudflare cdn scripts.

    Just wanted to put some attention to external scripts being registered with wp_enqueue_script by protocol relative url.

    Plugin Author Khang Minh

    (@oddoneout)

    Thanks for the patch, actually this was fixed in 1.3.0-beta. I will put a download link for 1.3.0 tomorrow and you can check it out if you want, loads of new features as well ??

    Thread Starter Maik Penz

    (@goatherd)

    Found your github account (and spammed it). Glad you mentioned the beta.

    I will have a look at it tomorrow and resolve this issue accordingly.

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘broken protocol-relative url detection’ is closed to new replies.