Bug (+ fix!!!): not checking the box has no effect

I’ve seen several posts about this bug already and was looking at fixing this myself a while, but never got round to it to dig deep enough before.

Basically, when Agreeable is active and a user does not put a checkmark in the Agree to terms checkbox, the new user registration would still go through, even though the whole point of this plugin is that it shouldn’t.

Anyway, I’ve found the bug now.

In the agreeable.php in the ag_display_terms_form function line 352, it says:
if( ( $type != 'login' ) || ( $type != 'register' ) || ( $type != 'comments' ) ) {

This is a nonsense condition as it will always result in true ($type can not hold three different values).

If you change that line to read:
if( ( $type != 'login' ) && ( $type != 'register' ) && ( $type != 'comments' ) ) {

things suddenly start working again.

There are prettier ways to do this, but at least it’s working again now.

Hope this helps other people who have run into the same bug.

It would be great if the plugin would get an update so things work again out of the box.