Bug fix suggestions

  • Resolved awhig

    (@awhig)


    11 years, 1 month ago

    Hi Ajay,

    Started using your plugin. Thanks for the work.

    A couple of suggestions.

    I noticed when I clicked the generated links to change the Results per page, the title of my results page was always “Page not found”. This was because the generated link did not use the home page url. The generated link was https://www.mysite.com/wphome/?s=test&limit=20

    You used get_option(“siteurl”). I fixed this by using the home_url() function instead in get_bsearch_header. The generated link is now https://www.mysite.com/?s=test&limit=20.

    Also the search parameter was not url encoded in those links as well, so I also encoded the string using the urlencode() function before generating the link.

    The search string is also not encoded in the page links at the bottom of the results. I’ve fixed that in my copy as well.

    Thanks,
    Rich

    https://www.ads-software.com/plugins/better-search/

Viewing 3 replies - 1 through 3 (of 3 total)
  • Plugin Author Ajay

    (@ajay)

    Rich, do you want to drop me your copy at me AT ajaydsouza DOT com and I’ll incorporate this in a new version

    Thread Starter awhig

    (@awhig)

    Hi Ajay,

    I sent you a copy of my file with the changes.

    Rich

    Plugin Author Ajay

    (@ajay)

    Rich,

    Received your email. Thanks for this. I’ll put through the changes in the next version

Viewing 3 replies - 1 through 3 (of 3 total)
  • The topic ‘Bug fix suggestions’ is closed to new replies.