[Bug report Fix] Shortcodes

  • Resolved bones852

    (@bones852)


    10 years, 2 months ago

    Hi there!
    Thank you for this awesome plugin.

    I’ve noticed that some shortcode attributes (like “overlayClose” and “overlayEscClose”) are not working. And after a couple of hours of digging I finally have found what’s wrong.

    According to this WordPress Codex page about “add_shortcode” function (look in “Notes” section):

    Shortcode attribute names are always converted to lowercase before they are passed into the handler function. Values are untouched.

    So when “shortcode_atts” is combining default values and values provided in shortcode it throws away some of last ones.

    To fix this you should make all names of attributes in lowercase (/include/shortcodes.php and /include/deprecated.php).

    Take care!

    https://www.ads-software.com/plugins/easy-modal/

Viewing 1 replies (of 1 total)
  • Plugin Author Daniel Iser

    (@danieliser)

    The ones in deprecated cant be changed as they are to not break older shortcodes. But all they do their is simply remap to new keys.

    What really needs to change is the usage in shortcodes which i will adjust to use all lowercase. Thanks for the tip.

    Will get this patched and likely add more to the deprecated file to correct issues for those who already have created them using the camelCase attr names.

Viewing 1 replies (of 1 total)
  • The topic ‘[Bug report Fix] Shortcodes’ is closed to new replies.