Bug which causes settings to be un-settable

Hi,

One of our clients was having a problem where they would enter their settings and click “Update options”, and none of the options would be updated.

I tracked it down to twitget.php around line 679:

$twitget_settings = get_option('twitget_settings');
    ...
    if(isset($_POST['twitget_username']) && is_array($twitget_settings) === true) {
        ...
        update_option('twitget_settings', $twitget_settings);
        ...
    }

For whatever reason, the option “twitget_settings” was not set on the client’s site. So logically to set twitget_settings, twitget_settings must already be set, which makes setting twitget_settings impossible.

WordPress: 3.8. Twitget: 3.3.1.

Thanks,
Tom Adams
dxw

https://www.ads-software.com/plugins/twitget/