Bug with list widget no_upcoming_events

  • Resolved Erich Munz

    (@erich_k4wp)


    8 years, 1 month ago

    in /the-events-calendar/src/Tribe/List_Widget.php

    Line ~ #65

    public function widget_output( $args, $instance, $template_name = 'widgets/list-widget' ) {
		global $wp_query, $tribe_ecp, $post;

		$no_upcoming_events = true;  // IS SET HERE!

		$instance = wp_parse_args(
			$instance, array(
				'limit' => self::$limit,
				'title' => '',
			)
		);
        
        // BUT SHOULD BE UPDATED WITH THE ACTUAL $instance VALUE
        $no_upcoming_events = $instance['no_upcoming_events']; // WORKAROUND ADDED BY ERICH

    $no_upcoming_events is always true, so the events-list-widget in a sidebar will not be visible if the “no_upcoming_events” is set two false in the widget settings

Viewing 4 replies - 1 through 4 (of 4 total)

  • Hi, Erich.

    Thanks for reporting this issue. I’ve logged it as a bug for us to fix.

    Sorry you experienced this, and thanks for your patience in understanding as our developers evaluate, assign, and fix this bug in a future update (likely weeks, not days, at the earliest).

    Brook

    (@brook-tribe)

    Hey Erich,

    I really appreciate you taking the time to report a suspected bug.

    I wanted to reach out and ask you: is this now fixed when you run the latest versions of our plugins? I just retested for this issue, and another team member did as well. On both our systems the message is now displaying as expected.

    You mentioned the /wp-content/plugins/the-events-calendar/src/Tribe/List_Widget.php file. At least on current versions of the plugin, the $no_upcoming_events variable will soon get overriden after the lines you mentioned. They will be overridden by the two extract() functions that get called, which of course will redeclare any variables passed. Thus, the line you added should not be needed on current versions of the plugin.

    Please let us know if you have any questions. Cheers!

    – Brook

    Thread Starter Erich Munz

    (@erich_k4wp)

    Hi Brook,

    yes, it is fixed in the latest version!

    Erich

    Brook

    (@brook-tribe)

    Excellent news! Thank you so much for getting back.

    – Brook

Viewing 4 replies - 1 through 4 (of 4 total)
  • The topic ‘Bug with list widget no_upcoming_events’ is closed to new replies.