Bunch Problems/Issues
-
`Hey,
I am also developer and checked some of your code and would like to repot a lot of problems and bugs.
Lazy Loading images:
1. You are using this placeholder for images https://prnt.sc/FiuDs8UmRw1p , it’s 1X1 square image, but if the real image aspect ratio is different(the most time) after you will show image the page will jump and will increase layout shift. The second it can break sliders,masonry and any js which is calculate the w/h of images. You are loading images using this https://prnt.sc/pACSXCOhSBfP and it’s normal? it’s reflow all page every time(https://csstriggers.com/) and block main thread, this solution was actuall 10+ years ago, who is doing it in 2022 you need to use this(https://developer.mozilla.org/en-US/docs/Web/API/Intersection_Observer_API). Changing src/srcset also block main thread, you should use image decode(https://developer.mozilla.org/en-US/docs/Web/API/HTMLImageElement/decode). And you ignoring these rules https://prnt.sc/pACSXCOhSBfP .
Lazy Loading Video:
Doing lazyloading of video like this https://prnt.sc/wQbCsdzW9-7G , will harm SEO, you should keep src and use preload=none instead of changing src to data-src.
Frontend optimizations:
You are moving js files to upload directory https://prnt.sc/9JogZICxmcKL , but doing it you are breaking any js that are using this https://developer.mozilla.org/en-US/docs/Web/API/Document/currentScript or dynamic imports(https://v8.dev/features/dynamic-import) becase they can use path like this ‘./some path’. if you are doing you should take care of that ,it’s the same if I will combine css and will not take care of css @imports relative paths .
There are a lot of problems and I checked only 15% of the code. My report doesn’t have point to say you have bad code, you have very good product, the point to make it better.
Thanks.
- The topic ‘Bunch Problems/Issues’ is closed to new replies.