Cachebuster in URL persists even with setting turned off

I’ve done some additional testing and found a bit more about what’s going on:

If you check the “Remove Cache Buster Query Parameter” this successfully marks the option as true in the options table. This basic test looks good and works:

$test1 = new SW_CLOUDFLARE_PAGECACHE();
$test2 = new SWCFPC_Cache_Controller( 'demo', $test1 );
echo $test2->remove_cache_buster(); // returns 1;

What it does do is successfully removes the inline JS code that modifies the links on the page. This take care of some but not all of the instances where the cachebuster appears. So the following things are now good:

• existing links on the page don’t have cachebusters added
• visiting pages like example.com/shop/ directly don’t add a cachebuster

But a few circumstances cause it to reappear:

• Anything that triggers a redirect causes it to be added. This could be as simple as leaving off the trailing slash – so example.com/shop/ is fine but example.com/shop causes a redirect to the version with the trailing slash and adds ?swcfpc=1
• Anytime you submit a form instead of following a link, the cachebuster is also added. For example visiting example.com/cart/ directly it’s fine… but if you go to a product page and add a product to the cart – then ?swcfpc=1 is tacked on to the end when you get to the cart page after the form submission.

Ok! I found the solution:

Just need to add if( $this->remove_cache_buster() ) return $location; near the top of function wp_redirect_filter in cache_controler.class.php

This matches the logic in function inject_cache_buster_js_code but it’s just not included in the redirect filter.

Hi,
Thanks for reporting this bug and the solution. I’ve added the fix. Can you please try downloading the patched version of the plugin from here and confirm that the issue has been fixed now?

Yup, that’s working for me!

Thanks for the quick reply and for the awesome plugin. It’s very odd that the official Cloudflare WP plugin is so limited and actually causes more problems than it solves. Thanks for filling a need in the community with this great plugin!

Thanks for confirming @squarecandy. ??

Also super happy to hear that you are loving the plugin. These patches will be added to the upcoming update of the plugin.