Cannot modify image / thumbnail sizes, bug with custom size

I can confirm that this is a problem.

Hi,

Can I please see screenshots of your settings page? Something similar to what I have here:

https://www.ads-software.com/plugins/contextual-related-posts/screenshots/

Also, do you have the default styles activated? If so, it doesn’t allow the image thumbnail sizes to be changed.

Hi Ajay,

here we go:

https://m15i.imgup.net/Bildschirmff2d.png
https://b68i.imgup.net/Bildschirm0c19.png
https://d65i.imgup.net/Bildschirme1ae.png
https://p40i.imgup.net/Bildschirm5109.png

Hope that helps with the debugging.

Hi, on the second thumbnail, I note that you’ve selected Medium. This is not the custom size, so images should, in theory, be 300×300. There appears to be a bug on the CSS part, which I need to take a look into.

Are you in a position to install this plugin: https://www.ads-software.com/plugins/display-all-image-sizes/

And, then see exactly what image is actually being pulled for each registered image size.

Also, what happens if you select Custom size and set it to 300x

Hi Ajay,

thanks for getting back. I installed the plugin “Display All Image Sizes” and afterwards set the custom image size to Custom (300px * 300px) like you asked.

The outcome stays the same, still only the small thumbnail size is being rendered and the setting has no effect at all (regenerated my thumbails first).

Also when I set it back to “medium” nothing changes.

This is the code being generated for our example image by CRP (same for “custom” and for “medium”):

<img src="/cs/wp-content/uploads/2011/02/Fotolia_4128238_XS-150x150.jpg" alt="some-alt-description" title="some-title" style="max-width:300px;max-height:300px;" class="crp_thumb crp_firstchild">

The image sizes are as follow:

full_
https://localhost:8888/cs/wp-content/uploads/2011/02/Fotolia_4128238_XS.jpg

medium_
https://localhost:8888/cs/wp-content/uploads/2011/02/Fotolia_4128238_XS-232×300.jpg

thumbnail_
https://localhost:8888/cs/wp-content/uploads/2011/02/Fotolia_4128238_XS-150×150.jpg

I deactivated the custom image sizes we generated within our theme to rule out any possible interference (compare screenshots from my last post, we had some additional sizes there), the problem persists though.

Thanks for your effort + Regards,
Henning

Couple of more questions to help me pin point. I’ve already filed an issue for me to look into.

1. Can you please try OTF Regenerate Thumbnails plugins.

As you know, the plugin doesn’t regenerate the thumbnails automatically. However, OTF will regenerate the thumbnails on the fly when required.

2. When you set it to Custom, you should see an additional image size i.e. crp_thumb that the previous plugin should give you. What do you see there?

Hi Ajay,

I went ahead and deactivated “Regenerate Thumbnails”, installed “OTF Regenerate Thumbnails”, changed the thumbnail size to “Custom”, set width & height to 400px and cleared the plugin cache.

The code that is generated:

<img src="/cs/wp-content/uploads/2011/02/Fotolia_4128238_XS-150x150.jpg" alt="some-alt-description" title="some-title" style="max-width:400px;max-height:400px;" class="crp_thumb crp_firstchild">

In the media overview I see

crp_thumbnail: 232×300

(the original image isn’t big enough, other images are though, there I see crp_thumbnail: 400×268 f.ex.)

Also tried on a different server, no changes.

Regards!

Thanks. Let me trying my set of debugging to see if I can fix this. I notice that you have crp_firstchild, which means it isn’t using a feature image but trying to pull the image from the post which could possibly be why we have this problem.

Do you see this on any post that has the feature image. Apologies for all the questions, but there are so many permutations that I need to find the correct one to replicate!

Hi Ajay,

no problem at all regarding the inquiries, glad to help. And very much appreciate you looking into this.

And you’re right – it has to do with pulling the images from the blogpost instead of using the featured image!

I have one image set as featured image and when this is displayed within CRP then it works just fine:

<img src="/cs/wp-content/uploads/2013/02/streit-400x266.jpg" alt="some-alt-description" title="some-title" style="max-width:400px;max-height:400px;" class="crp_thumb crp_featured">

Any further info needed?
Regards,

Henning

What CRP does is find the first child of a post. If it does so, then it tries to pull the ready made thumbnail from this.

https://github.com/ajaydsouza/contextual-related-posts/blob/master/contextual-related-posts.php#L1264

Now, relooking at my code, I realise there is a bug in this
Do you mind editing the contextual-related-posts file and replacing the below function. What I’ve changed is to pull the image size now instead of the thumbnail which is what kept getting pulled for the “firstchild”

function crp_get_first_image( $postID ) {
	global $crp_settings;
	$args = array(
		'numberposts' => 1,
		'order' => 'ASC',
		'post_mime_type' => 'image',
		'post_parent' => $postID,
		'post_status' => null,
		'post_type' => 'attachment',
	);
	$attachments = get_children( $args );
	if ( $attachments ) {
		foreach ( $attachments as $attachment ) {

			$image_attributes = wp_get_attachment_image_src( $attachment->ID, $crp_settings['thumb_size'] );

			/**
			 * Filters first child attachment from the post.
			 *
			 * @since	2.0.0
			 *
			 * @param	array	$image_attributes[0]	URL of the image
			 * @param	int		$postID					Post ID
			 */
			return apply_filters( 'crp_get_first_image', $image_attributes[0], $postID );
		}
	} else {
		return false;
	}
}

Brilliant, that’s it! Your fix works like charm.

One thing remaining: The custom settings still inputs the “max-width” & “max-height” variables (using the standard “medium” setting), should also be cleaned up. Not that it matters so much, I can set it to 9999px or 100% and won’t be bothered but just wanted to point that out again.

Otherwise: Thanks so much & keep up the good work.

Best regards,
Henning

I need to fix the max-width & max-height settings. that is clearly a bug.

Thanks for testing the above. I’ll implement this fix in my plugin for the next release that I’m working on.

I can report the same problem, with Featured Images and the images within the post. Thanks for working on it.

Hi,

Please see the fix above that I gave Henning which should work for now until the next release.