Hi Johan –
There are a few issues with this update ??
1) The variable contend_id isn’t defined – this is because you’ve not set the scope, and are testing for = “” instead of typeof() == ‘undefined’
2) Shouldn’t the jQuery hook come inside a jQuery(document).on(‘ready’) block to be sure it executes after the DOM has loaded? Right now it would appear the hook is called before the <select> element has been written.
3) Multiple WYSWYG editors on a page still generate elements with the same ID attribute, like
<div id="content-block-form">. I’d suggest avoiding IDs in your injected code – instead use unique sets of classes.
4) Maybe remove the inline “onclick” handler, and just use jQuery to hook the click button
5) Should probably comment out/ remove the console.log() line ??
I would submit this (or something like it) as an alternative (dummy content blocks added for clarity)
<script type="text/javascript">
jQuery(document).ready(function($) {
// Iterate through all Content Block groups
$('.content-block-form').each(function(index, element) {
// Hook the Insert button
$('input.insert', element).on('click', function(evt) {
// Get select element and selected ID
var win = window.dialogArguments || opener || parent || top,
$el_select = $(this).closest('.content-block-form').filter('select.add-content-block-id'),
content_block_id = $el_select.val();
if( content_block_id == "" ) {
alert( "Please select a Content Block" );
return false;
};
// Success
win.send_to_editor( "[content_block id=" + content_block_id + "]" );
});
});
});
</script>
<div class="content-block-form">
<h3>Insert Content Block</h3>
<p>
Select a Content Block below to add it to your post or page.
</p>
<p>
<select class="add-content-block-id">
<option value="">Select a Content Block</option>
<option value="1">Test content block 1</option>
<option value="2">Test content block 2</option>
<option value="3">Test content block 3</option>
</select>
</p>
<p>
<input type="button" class="button-primary insert" value="Insert Content Block" />
</p>
</div>
I’ve not tested this code or anything, but something close to this should work for multiple editors and avoid conflicts.
Hope it helps!!
