Okbet gaming withdrawal.Claim Your Free 999 Pesos Bonus Today

Resolved Birgir Erlendsson (birgire)
(@birgire)

3 years, 1 month ago
Hi, shouldn’t this be a capability check instead of a role check:
```
		/**
		 * Show settings menu
		 */
		public function wpmm_item_settings_load(){
			if(! current_user_can('administrator')) {
                return;
            }
```
https://github.com/themeum/wp-megamenu/blob/020635c6c89e4e952f05e322536b8a5006f14b8a/classes/class.wp-megamenu-base.php#L227

to make it easier for custom roles to access it?

See also e.g. https://developer.www.ads-software.com/reference/functions/current_user_can/

While checking against particular roles in place of a capability is supported in part, this practice is discouraged as it may produce unreliable results.

Thanks

Viewing 10 replies - 1 through 10 (of 10 total)

Md. Jobayer Al Mahmud
(@jobayertuser)

3 years, 1 month ago

Hello @birgire,

Of course, you can customize it but as this is already in the role check option set from before you have to change many of the places for so we don’t recommend it to our users to do that it’s a matter of conflicting issues.

Thread Starter Birgir Erlendsson (birgire)
(@birgire)

3 years, 1 month ago

Thanks for replying @jobayertuser

Sorry I don’t follow

> Of course, you can customize …

How can I do that without editing plugin code or assign administrator role to other roles.

So this is not recommended for custom roles?

Thanks

Md. Jobayer Al Mahmud
(@jobayertuser)

3 years, 1 month ago

Hello @birgire,

Actually, there is no plugin or addons to add the custom capability to our Tuor LMS thus you can perform this action without modifying our raw code.

Thread Starter Birgir Erlendsson (birgire)
(@birgire)

3 years, 1 month ago

Hello @jobayertuser

I’m not using Tutor LMS

If I understand correctly the megamenu plugin is only suitable for the hardcoded administrator role.

thanks

Md. Jobayer Al Mahmud
(@jobayertuser)

3 years, 1 month ago

Hello @birgire,

Ok, please allow me sometime thus I can provide you a custom solution. Though our support policy don’t provide any custom solution still if you insisting I will provide you some solution as per I can.

Thread Starter Birgir Erlendsson (birgire)
(@birgire)

3 years, 1 month ago

Awesome, I’m sure it would help others too, as there are similar threads out there regarding this topic.

Shibbir Ahmed
(@creativeartbd)

3 years, 1 month ago

Hello @birgire

Can you tell me why you need the capability check instead of the role check? As you know that each role has a list of capabilities.

Kind Regards.
Thread Starter Birgir Erlendsson (birgire)
(@birgire)

3 years, 1 month ago
Hello @creativeartbd

To be able to use a custom role and checking for roles is discouraged per Codex.

I checked and compered to another plugin called Max Mega Menu (I’m not related to that plugin) and there it’s done developer friendly with e.g.:

https://plugins.trac.www.ads-software.com/browser/megamenu/trunk/classes/menu-item-manager.class.php#L93
```
98	                public static function ajax_save_menu_item_settings() {
99	
100	                        check_ajax_referer( 'megamenu_edit' );
101	
102	                        $capability = apply_filters( 'megamenu_options_capability', 'edit_theme_options' );
103	
104	                        if ( ! current_user_can( $capability ) ) {
105	                                return;
106	                        }
```
Best regards
Thread Starter Birgir Erlendsson (birgire)
(@birgire)

3 years, 1 month ago

Here are similar support threads I just found that seems to be related to this topic:

https://www.ads-software.com/support/topic/can-editor-edit-mega-menu/

https://www.ads-software.com/support/topic/allow-editors-to-make-changes-2/

Shibbir Ahmed
(@creativeartbd)

3 years, 1 month ago

Hello @birgire

Thanks for your suggestions.

Our developer will look at this and if required they will adjust the code.

Kind Regards.

Viewing 10 replies - 1 through 10 (of 10 total)

The topic ‘Capability check instead of a role check’ is closed to new replies.