Causes problems with AMP plugin

  • The HTTPS url rewriting leads to invalid URL errors in AMP.

    What this plugin does.
    It strips the protocol i.e. removes http: and https: from resource URLs using the following regex.
    /(<(script|link|base|img|form)([^>]*)(href|src|action)=[\"'])http:\\/\\//i

    What I feel it should do is rewrite http to https only if necessary or provide a filter to exclude URLs which contain certain words by using ‘preg_replace_callback’ if possible.

    https://www.ads-software.com/plugins/cloudflare/

Viewing 2 replies - 1 through 2 (of 2 total)

  • same problem here!
    I solved “manually” adding my URL into header and buffer regexps

    # diff cloudflare.php cloudflare.php.orig
550,551c550,551
<         $re     = "/(<(script|link|base|img|form)([^>]*)(href|src|action)=[\"'])https?:\\/\\/www.ilovevaldinon.it/i”;
<         $subst  = "$1//www.ilovevaldinon.it";
---
>         $re     = "/(<(script|link|base|img|form)([^>]*)(href|src|action)=[\"'])https?:\\/\\//i";
>         $subst  = "$1//";
581,582c581,582
<             $re     = "/https?:\\/\\/www.ilovevaldinon.it/i";
<             $subst  = "//www.ilovevaldinon.it";
---
>             $re     = "/https?:\\/\\//i";
>             $subst  = "//";

    URLs external to my domain must not be changed.

    +1

Viewing 2 replies - 1 through 2 (of 2 total)
  • The topic ‘Causes problems with AMP plugin’ is closed to new replies.