cg-feedread xhtml validation

https://validator.w3.org/check?uri=http%3A%2F%2Fwww.justbuggeroff.net%2F&charset=%28detect+automatically%29&doctype=%28detect+automatically%29&ss=1&verbose=1#line-473

I;m not expert but it seems you’re creating a list without an opening and closing
<ul> or
<ol> tag for the first error.

For the second error I don’t believe you can place a h2 tag within a span tag, try placing it outside, or try something like this in your css:

h2.feeddescription {whatever style here} then in your content use <h2 class="feeddescription">

Might work. Don’t take my word for it ??

Simon, I’ll take a look at it and get back to you. I’m admittedly not a validation freak these days — just keeping up with basic support and enhancement.

The first one can be solved on your end — don’t use my sideblock functions, just wrapper the feed output as if it were any other sidebar block in your sidebar. It’s creating things that don’t work properly within a Kubrick format (and yes, may not be ‘proper’ in any case.. ?? ).

The second one I have to fix directly. I think. My apache/sql/php machine is now my ‘secondary’ pc, and only when I turn it on can I work on this stuff… ?? ?? But seems like I may have mis-wrapped something. I had changed a lot from spans to divs, then added in the h2 to better support sidebars like Kubrick, and must have broken validation.

(Of course, validation could have been broken for months, and I’d never have known… ?? ).

-d

David, I took your advice and used the ‘basic’ feed The only remaining ‘error’ was the nesting of the h2 tag. I changed the lines

677, 679 and 693 of cg-feedread.php to

$output .= “<h2><span class=’feedTitleGraphic’>”.$lf;
$output .= “<h2><span class=’feedDescription’>”.$lf;
$output .= “</span></h2>”.$lf;

respectively and now it validates quite happily as xhtml transitional.

Anyone trying to do this should remember to delete the files contained within the cache_feedread directory otherwise you won’t see any difference.

Also in the block style feed if you change

start_block(“RSS FEEDS”, “feedread”, “li”); to
start_block(“RSS FEEDS”, “feedread”);

everything validates OK.
(I am using the default theme for WP 1.5.1)

Si ??

Cool.

I just redid some of the code anyway. I have replace the title spans with divs (in case people want to float, or otherwise control), the h2 now only shows up in wp styling (style==1) and still shows up inside the div (since that’s valid, and so floating the div would float the h2 inside…), and some other minor wrappering.

I also isolated the targeted window stuff, so CG-FeedRead now has its own control variable ($feedTargetWindow in future releases…). target= isn’t supposedly a valid xhtml attribute (which is just plain stupid), so I’ve kept it a overrideable var in each of the plugins.

and yes, your start_block solution is the right thing to do if using my block functions, which use DIVs primarily, but can add in whatever styling you need (an li is typical wrapping). If you already have the li on the outside, you don’t need to have start_block output it. But, you also don’t need to use start_block at all, just output your own heading if you want one… it can be excess output.

CG-FeedRead (and CG-Amazon as well), don’t assume any particular ‘wrappering’ around their output. So you want them to be in the sidebar enclosed in an li, just do the li manually, and leave the FR output inside.

-d

Nice one!

<div> more flexible, thanks.
Totally agree about “target=”, makes a ‘news blog’ a bit of a pain unless you use Firefox and open external links in a new tab.

Thanks again

Simon ??

let us know when it goes up on Chait.net

I’m getting this error for each post in each feed:

#

Line 1454, column 131: character “$” not allowed in attribute specification list

…lock available-see MLS 77377…” $CGTargetWindow>

The “$CGTargetWindow” seems to be the issue.

(URL is https://www.tom-hanna.org and I’m validating at validator.w3.org)

tom – You are running some old version of FeedRead. Try grabbing the latest CG-PowerPack, as the output formatting changed.

simon – New release of PP hopefully up tonight. I’ve been sick for five days, haven’t gotten a thing done… ??

-d

hey guys – the 1.5.2 release is now out/up. Definitely get it, as it should address both your issues.

-d

Cheers David,

Everything seems to be OK.
Like the new CG-Ref!
Feeds working OK.

thanks again.

Simon