Checkout Custom Field – 2 Bugs?

  • Resolved LordLiverpool

    (@lordliverpool)


    7 years, 4 months ago

    Hello Booster

    I have two possible issues with your Checkout Custom Fields module.

    I’m trying to add a custom field of “Delivery Time”. As we make deliveries from 7am – 7pm.

    Therefore the TimePicker is no good because it allows a website visitor to pick any time of the day. i.e. 12am-12pm.

    So I decided to try and use the select option as a work around, entering the desired values, one per line:

    Booster_Settings

    This looks great on the checkout page:

    Checkout_Field

    Although I’m a little confused as to why it defaults to 15:00 hours? When I have a placeholder of “Choose a Time”. ???

    OK secondly:

    Scenario 1:

    If I choose a different time from the combo box then the time I pick is propagated to the order-received page and the email. Everything behaves as expected. Great ??

    Scenario 2:

    If I don’t choose a different time and leave the default value of 07:00 in place then when I complete my order, the time always shows up as a number, not so great ??

    Checkout_Time

    Can you please help? What am I doing wrong?

    Best Regards

    The page I need help with: [log in to see the link]

Viewing 6 replies - 1 through 6 (of 6 total)
  • Thread Starter LordLiverpool

    (@lordliverpool)

    Hi Booster

    Any luck with this one?

    Best Regards

    Thread Starter LordLiverpool

    (@lordliverpool)

    Hi Booster

    Are you able/willing to fix this, yes/no? I’d appreciate an answer, so I can decide what to do next. Thanks very much.

    Best Regards

    Hi @lordliverpool,

    Sorry for a delay.

    1. Regarding why it defaults to 15:00 hours – the field defaults to previous value set by customer. That is – first time he visits the checkout, the value defaults to “Choose a Time”. When customer makes his order and selects some delivery time, the time is saved for that customer, so when he visits checkout again, value defaults to his previous choice. Please also note, that placeholder is not the same as default value. For “select” field type, placeholder is just added as first choice in the list (with empty value).

    2. Regarding numbers instead of text – yes, I can confirm there is some issue here. However I think it’s not related if you left the default value, or selected new – it seems that all values starting from “10:00” have this issue. Already fixing it, will get back to you about that in a minute.

    Best regards,
    Tom

    Update: Hopefully I’ve managed to fix the issue. Please download the development version here – https://booster.io/dev/. You will need to uninstall the old plugin version first (don’t worry your saved settings won’t disappear). If you have Booster Plus – please contact me on [email protected] and I will send you Plus dev version.

    The issue only appeared when a) numeric (or “almost” numeric, i.e. numeric after sanitization, like in your case) values were used in select options, and b) some placeholder was set. When both conditions happened – PHP’s array_merge() function changed the keys for options array and value was displayed incorrectly.

    Please let me know if it’s now working as expected.

    Again sorry for the delay.

    Best regards,
    Tom

    Thread Starter LordLiverpool

    (@lordliverpool)

    @algoritmika

    My turn to apologise, sorry for my slow response, the weekend got in the way.

    Thank you for your detailed response it’s appreciated.

    In the end I decided to simplify my delivery times. Going from 12 “numeric” select options e.g. 07:00 to 19:00. To just two “literal string” options of ‘am delivery’ and ‘pm delivery’. So because I’m using strings everything works fine at my end now.

    Apologies for making you write code, but I’m sure your plugin is now more robust because of this support thread.

    I wish to express my appreciation for your help, thanks very much!

    Best Regards

    Hi @lordliverpool,

    Thanks for the feedback. No need to apologize – it was still a bug, even if it occurred only with specific conditions, so I’m happy we’ve fixed it.

    Again, sorry for my delays in replies.

    Best regards,
    Tom

Viewing 6 replies - 1 through 6 (of 6 total)
  • The topic ‘Checkout Custom Field – 2 Bugs?’ is closed to new replies.

Tags