• Resolved codejp3

    (@codejp3)


    Some of the buttons in functions.php > bsp_display_buttons function are missing the one-half / one-third classes when there’s 2, 3, or 4 buttons.

    Not going to break it down per-button count because I’m sure you can see it pretty easy when you look, but it’s between lines 190-290ish.

    Had buttons that looked like they were floating/misaligned. Added the appropriate bsp-one-half / bsp-one-third classes and all is good now.

Viewing 5 replies - 1 through 5 (of 5 total)
  • Thread Starter codejp3

    (@codejp3)

    replying to mark as resolved…

    Thread Starter codejp3

    (@codejp3)

    Oh, I’ll also add, that I made a few CSS changes. Couldn’t get them to look aligned properly with unequal width % and margin-right.

    Instead I set

    /* bsp-one-half */
    margin-right: 0;
    width: 50%;
    
    /* bsp-one-third */
    margin-right: 0;
    width: 33.33%;

    Looks proper on my end now.

    Thread Starter codejp3

    (@codejp3)

    One more follow-up. The “Mark All Topics As Read” button is slightly different than the others. Probably because it’s a built-in form.

    I played around 1, 2, 3, and 4 buttons, and with the order for the buttons, and that’s when it becomes obvious. “Mark All Topics As Read” is slightly offset vertically from the others.

    Compensating for the padding set in the .bsp_button1 class, an equal negative offset for just the “Mark All Topics As Read” form input button makes them all align perfectly:

    
    input.bsp_button1 {
    	margin-top: -7px;	
    }
    

    I THINK that’s it related to the top buttons and alignments. They’re all aligned perfectly, regardless of how many buttons and which order.

    Problem is, this isn’t very customizable for end-users. If someone changes the top or bottom padding size of .bsp_button1 (or their own custom class), then the input button for “Mark All Topics As Read” has to be handled separately with an equal negative top margin comparable to the padding of the rest. Just something to think about.

    Thread Starter codejp3

    (@codejp3)

    Now I noticed that when viewing the forum index that has the “mark as read” button to the left and search form to the right, the “mark as read” button has 7px cut off from the top.

    Fixed one problem, but caused another. ??

    To isolate just the -7px offset on single forum pages, but display as normal on the forum index page, I got a little more specific with the targeted CSS selector:

    
    /* only when the "mark as read" button is used in-line with other buttons */
    div.bsp-center > form > input.bsp_button1 {
    	margin-top: -7px;	
    }
    

    The button displays properly by itself, and perfectly in-line with all other buttons everywhere it’s used.

    Problem(s) solved…..but that makes it even less user-friendly for personal customization. Hmmm, haven’t come up with a solid solution for this yet. I’ll keep thinking about it and get back to you if I come up with something.

    Plugin Author Robin W

    (@robin-w)

    thanks, and thanks fro the updates.

    Yes if you come up with code that will be useful to add, let me know ??

Viewing 5 replies - 1 through 5 (of 5 total)
  • The topic ‘classes bsp-one-half / bsp-one-third missing’ is closed to new replies.