Code and Performance Improvements

Hi Oliver,

thanks for the plugin. Maybe i will use it. I will first have to have a better unterstanding about Google News….

But what I spotted right on the fly are somre potentioal big performance improvements:

1.) Query adn throw away
If you go to the sourceode to the line:
if (get_option(‘googlenewssitemap_tagkeywords’) == ‘on’)
you will see, that you do before a very expensive Query, and in case this feature is disabled, you throw away the TAG ressults. This is not good and slows down the website. Please do first check if it is turned on, then query for the TAGS!

2.) Use get_option

// Fetch options from database
$permalink_structure = $wpdb->get_var(“SELECT option_value FROM $wpdb->options
WHERE option_name=’permalink_structure'”);
$siteurl = $wpdb->get_var(“SELECT option_value FROM $wpdb->options
WHERE option_name=’siteurl'”);

This is also not goog querying directly from the database, as option values are normally cached by wordpress inside and will come out of memory, so the currenty implementation above will lead to to two unnecessary DB rquests which also slows down the site.

Thanks

https://www.ads-software.com/plugins/working-news-sitemap-generator-for-google-news-2014/